Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: components/contextual_search/renderer/contextual_search_wrapper.cc

Issue 1385663002: [Contextual Search] Add Mojo-enabled API component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a RenderFrameObserver to the Wrapper and clear the gin Handle OnDestruct of the render frame. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/contextual_search/renderer/contextual_search_wrapper.cc
diff --git a/components/contextual_search/renderer/contextual_search_wrapper.cc b/components/contextual_search/renderer/contextual_search_wrapper.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8858dd1674a831403b24ac497bc7e16515129c77
--- /dev/null
+++ b/components/contextual_search/renderer/contextual_search_wrapper.cc
@@ -0,0 +1,100 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/contextual_search/renderer/contextual_search_wrapper.h"
+
+#include "base/strings/string_util.h"
+#include "content/public/common/service_registry.h"
+#include "content/public/renderer/chrome_object_extensions_utils.h"
+#include "content/public/renderer/render_frame.h"
+#include "gin/arguments.h"
+#include "gin/object_template_builder.h"
+#include "third_party/WebKit/public/web/WebFrame.h"
+#include "third_party/WebKit/public/web/WebKit.h"
+#include "third_party/WebKit/public/web/WebLocalFrame.h"
+#include "v8/include/v8.h"
+
+namespace {
+
+static const char kContextualSearchObjectName[] = "contextualSearch";
+static const char kSetCaptionMethodName[] = "setCaption";
+
+} // namespace
+
+namespace contextual_search {
+
+gin::WrapperInfo ContextualSearchWrapper::kWrapperInfo = {
+ gin::kEmbedderNativeGin};
+
+// static
+void ContextualSearchWrapper::Install(content::RenderFrame* render_frame) {
+ // NOTE: Installing new v8 functions that can access Chrome native code
+ // requires a security review! We did an exhaustive search for a better
+ // way to implement a communication channel between the page and Chrome,
+ // but found nothing better.
+ // TODO(donnd): use a better communication channel once that becomes
+ // available, e.g. navigator.connect API. See crbug.com/541683.
+ // TODO(donnd): refactor some of this boilerplate into a reusable
+ // method. This was cribbed from MemoryBenchmarkingExtension.
+ v8::Isolate* isolate = blink::mainThreadIsolate();
+ v8::HandleScope handle_scope(isolate);
+ v8::Local<v8::Context> context =
+ render_frame->GetWebFrame()->mainWorldScriptContext();
+ if (context.IsEmpty())
+ return;
+
+ v8::Context::Scope context_scope(context);
+ ContextualSearchWrapper* wrapped_object(
+ new ContextualSearchWrapper(render_frame));
+ gin::Handle<ContextualSearchWrapper> wrapper =
+ gin::CreateHandle(isolate, wrapped_object);
+ if (wrapper.IsEmpty())
+ return;
+
+ v8::Local<v8::Object> chrome =
+ content::GetOrCreateChromeObject(isolate, context->Global());
+ chrome->Set(gin::StringToV8(isolate, kContextualSearchObjectName),
+ wrapper.ToV8());
+ wrapped_object->SetGinHandle(wrapper);
jochen (gone - plz use gerrit) 2015/12/04 13:21:36 don't hold on to the wrapper
Donn Denman 2015/12/09 00:57:33 Done.
+}
+
+ContextualSearchWrapper::ContextualSearchWrapper(
+ content::RenderFrame* render_frame)
+ : RenderFrameObserver(render_frame) {}
+
+ContextualSearchWrapper::~ContextualSearchWrapper() {}
+
+gin::ObjectTemplateBuilder ContextualSearchWrapper::GetObjectTemplateBuilder(
+ v8::Isolate* isolate) {
+ return gin::Wrappable<ContextualSearchWrapper>::GetObjectTemplateBuilder(
+ isolate)
+ .SetMethod(kSetCaptionMethodName, &ContextualSearchWrapper::SetCaption);
+}
+
+void ContextualSearchWrapper::EnsureServiceConnected() {
+ if (!contextual_search_js_api_service_ ||
+ !contextual_search_js_api_service_.is_bound()) {
+ render_frame()->GetServiceRegistry()->ConnectToRemoteService(
jochen (gone - plz use gerrit) 2015/12/04 13:21:35 you have to null-check render_frame() before using
Donn Denman 2015/12/09 00:57:33 Done.
+ mojo::GetProxy(&contextual_search_js_api_service_));
+ }
+}
+
+void ContextualSearchWrapper::SetGinHandle(
+ gin::Handle<ContextualSearchWrapper> handle) {
+ gin_handle_ = handle;
+}
+
+void ContextualSearchWrapper::OnDestruct() {
+ if (!render_frame() && !gin_handle_.IsEmpty()) {
jochen (gone - plz use gerrit) 2015/12/04 13:21:36 this method should be empty, it's just avoid that
Donn Denman 2015/12/09 00:57:33 Done.
+ gin_handle_.Clear();
+ }
+}
+
+void ContextualSearchWrapper::SetCaption(const std::string& caption,
+ bool does_answer) {
+ EnsureServiceConnected();
jochen (gone - plz use gerrit) 2015/12/04 13:21:36 if render_frame() is null, you can't SetCaption
Donn Denman 2015/12/09 00:57:33 Done.
+ contextual_search_js_api_service_->HandleSetCaption(caption, does_answer);
+}
+
+} // namespace contextual_search

Powered by Google App Engine
This is Rietveld 408576698