[Contextual Search] Add Mojo-enabled API component.

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include "base/command_line.h"
 #include "base/debug/crash_logging.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
@@ skipping 15 matching lines @@
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/locale_settings.h"
 #include "chrome/grit/renderer_resources.h"
 #include "chrome/renderer/banners/app_banner_client.h"
 #include "chrome/renderer/benchmarking_extension.h"
 #include "chrome/renderer/chrome_render_frame_observer.h"
 #include "chrome/renderer/chrome_render_process_observer.h"
 #include "chrome/renderer/chrome_render_view_observer.h"
 #include "chrome/renderer/content_settings_observer.h"
+#include "chrome/renderer/contextualsearch/contextual_search_wrapper.h"
 #include "chrome/renderer/external_extension.h"
 #include "chrome/renderer/loadtimes_extension_bindings.h"
 #include "chrome/renderer/media/chrome_key_systems.h"
 #include "chrome/renderer/net/net_error_helper.h"
 #include "chrome/renderer/net_benchmarking_extension.h"
 #include "chrome/renderer/page_load_histograms.h"
 #include "chrome/renderer/pepper/pepper_helper.h"
 #include "chrome/renderer/plugins/non_loadable_plugin_placeholder.h"
 #include "chrome/renderer/plugins/plugin_preroller.h"
 #include "chrome/renderer/plugins/plugin_uma.h"
@@ skipping 461 matching lines @@
 #endif
 
   if (render_frame->IsMainFrame()) {
     // Only attach NetErrorHelper to the main frame, since only the main frame
     // should get error pages.
     new NetErrorHelper(render_frame);
 
     // Only attach MainRenderFrameObserver to the main frame, since
     // we only want to log page load metrics for the main frame.
     new page_load_metrics::MetricsRenderFrameObserver(render_frame);
+
+    // Install Contextual Search support in the main frame if needed.
+    if (base::CommandLine::ForCurrentProcess()->HasSwitch(

[Donn Denman, 2015/10/28 00:26:56]

Charlie, I'm thinking that we should change this to trigger off of mojo (like
Dom Distiller) instead of a command-line flag, and that should keep us from
adding our JS API based on the render process.  I would think that then the
reusing of the process would not be an issue.  Does that sound right to you?

[Charlie Reis, 2015/10/28 19:51:44]

Scoping it to a RenderFrame isn't a bad idea, but it won't help with the concern
about compromised renderer processes.  Once a malicious page takes over a
renderer process, it can pretend to be any RenderFrame in the process.  We
assume attackers can execute arbitrary code in the renderer process.

I think you'll still need to prevent process reuse for the overlay process.

+            switches::kContextualSearchProcess)) {
+      search::ContextualSearchWrapper::Install(render_frame->GetWebFrame());
+    }
   } else {
     // Avoid any race conditions from having the browser tell subframes that
     // they're prerendering.
     if (prerender::PrerenderHelper::IsPrerendering(
             render_frame->GetRenderView()->GetMainRenderFrame())) {
       new prerender::PrerenderHelper(render_frame);
     }
   }
 
   // Set up a mojo service to test if this page is a distiller page.
   new dom_distiller::DistillerJsRenderFrameObserver(

[Donn Denman, 2015/10/28 00:26:56]

Here's how Dom Distiller enables its API.

       render_frame, chrome::ISOLATED_WORLD_ID_CHROME_INTERNAL);
 
   PasswordAutofillAgent* password_autofill_agent =
       new PasswordAutofillAgent(render_frame);
   PasswordGenerationAgent* password_generation_agent =
       new PasswordGenerationAgent(render_frame, password_autofill_agent);
   new AutofillAgent(render_frame, password_autofill_agent,
                     password_generation_agent);
 }
 
@@ skipping 927 matching lines @@
 // chrome.system.network.getNetworkInterfaces provides the same
 // information. Also, the enforcement of sending and binding UDP is already done
 // by chrome extension permission model.
 bool ChromeContentRendererClient::ShouldEnforceWebRTCRoutingPreferences() {
 #if defined(ENABLE_EXTENSIONS)
   return !IsStandaloneExtensionProcess();
 #else
   return true;
 #endif
 }