Issue 13852039: Android: Fix incorrect sign on kMinScale in audio decoder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13852039: Android: Fix incorrect sign on kMinScale in audio decoder. (Closed)

Created:
7 years, 8 months ago by Raymond Toy (Google)

Modified:
7 years, 8 months ago

Reviewers:
bulach, Dale Curtis, DaleCurtis

CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Fix incorrect sign on kMinScale in audio decoder BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195304

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	webkit/media/android/audio_decoder_android.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Raymond Toy (Google)

Please review this one line fix where kMinScale had the wrong sign, causing negative samples ...

7 years, 8 months ago (2013-04-19 16:50:34 UTC) #1

bulach

lgtm, but please be more descriptive in the message log :) something like: Android: Fix ...

7 years, 8 months ago (2013-04-19 17:53:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/13852039/1

7 years, 8 months ago (2013-04-19 17:58:13 UTC) #3

Message was sent while issue was closed.

Change committed as 195304