Issue 13852037: [Android] Add native library to strip inputs

Issue 13852037: [Android] Add native library to strip inputs (Closed)

Created:
7 years, 8 months ago by cjhopman

Modified:
7 years, 8 months ago

Reviewers:
Yaron, nilesh

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org, Yaron

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Add native library to strip inputs If the native library changes, we should re-strip/copy it. Add it to the inputs so that we do that. BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195274

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
M	build/android/native_app_dependencies.gypi	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	build/android/strip_native_libraries.gypi	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	build/java_apk.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Yaron

https://codereview.chromium.org/13852037/diff/1001/build/android/native_app_dependencies.gypi File build/android/native_app_dependencies.gypi (right): https://codereview.chromium.org/13852037/diff/1001/build/android/native_app_dependencies.gypi#newcode55 build/android/native_app_dependencies.gypi:55: 'input_paths': ['<(native_binary)'], Shouldn't this be with the strip_native_libraries action ...

7 years, 8 months ago (2013-04-19 17:15:14 UTC) #2

cjhopman

https://codereview.chromium.org/13852037/diff/1001/build/android/native_app_dependencies.gypi File build/android/native_app_dependencies.gypi (right): https://codereview.chromium.org/13852037/diff/1001/build/android/native_app_dependencies.gypi#newcode55 build/android/native_app_dependencies.gypi:55: 'input_paths': ['<(native_binary)'], On 2013/04/19 17:15:14, Yaron wrote: > Shouldn't ...

7 years, 8 months ago (2013-04-19 17:30:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13852037/7001

7 years, 8 months ago (2013-04-19 17:34:54 UTC) #5

Message was sent while issue was closed.

Change committed as 195274

Expand Messages | Collapse Messages