Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Issue 13852033: Do not use visibility:visible in user pods (Closed)

Created:
7 years, 8 months ago by bartfab (slow)
Modified:
7 years, 8 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Do not use visibility:visible in user pods Per the CSS spec, marking part of a user pod as visibility:visible will make it accessible even if the entire account picker has visibility:hidden. BUG=232967 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/chromeos/login/user_pod_row.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
bartfab (slow)
Hi Nikita, Please take a look. I tested manually in a VM that the screen ...
7 years, 8 months ago (2013-04-19 11:35:43 UTC) #1
Nikita (slow)
lgtm
7 years, 8 months ago (2013-04-19 11:54:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/13852033/1
7 years, 8 months ago (2013-04-19 11:55:43 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-19 11:57:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/13852033/1
7 years, 8 months ago (2013-04-19 12:46:22 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 13:48:01 UTC) #6
Message was sent while issue was closed.
Change committed as 195169

Powered by Google App Engine
This is Rietveld 408576698