Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 13852013: Fix gyp files to allow ninja to build 64 bit on Mac. (Closed)

Created:
7 years, 8 months ago by mtklein
Modified:
7 years, 8 months ago
Reviewers:
bungeman-skia, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix gyp files to allow ninja to build 64 bit on Mac. Fix warnings that cropped up building as 64-bit. BUG= Committed: http://code.google.com/p/skia/source/detail?r=8814

Patch Set 1 #

Patch Set 2 : switched runtime asserts to their intended purpose, static asserts #

Patch Set 3 : fix build by handling kLineTypeCount in switch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M bench/DashBench.cpp View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M gyp/common_conditions.gypi View 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLSL.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/views/mac/SkTextFieldCell.m View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
Ben and I weren't sure what was going on with the (size_t) casts in those ...
7 years, 8 months ago (2013-04-18 22:17:35 UTC) #1
mtklein
On 2013/04/18 22:17:35, mtklein wrote: > Ben and I weren't sure what was going on ...
7 years, 8 months ago (2013-04-19 13:53:23 UTC) #2
bungeman-skia
The gypi change and cast in the .m lgtm. I'll leave the asserts to reed ...
7 years, 8 months ago (2013-04-19 14:05:13 UTC) #3
bsalomon
On 2013/04/19 14:05:13, bungeman1 wrote: > The gypi change and cast in the .m lgtm. ...
7 years, 8 months ago (2013-04-19 14:36:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/13852013/3001
7 years, 8 months ago (2013-04-19 19:14:56 UTC) #5
commit-bot: I haz the power
Retried try job too often on Skia_MacMiniLion_Float_Compile_Release_32_Trybot for step(s) BuildBench, BuildMost http://108.170.217.252:10117/buildstatus?builder=Skia_MacMiniLion_Float_Compile_Release_32_Trybot&number=28
7 years, 8 months ago (2013-04-19 19:28:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/13852013/13001
7 years, 8 months ago (2013-04-22 17:45:30 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-22 20:26:47 UTC) #8
Message was sent while issue was closed.
Change committed as 8814

Powered by Google App Engine
This is Rietveld 408576698