Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: tests/presubmit_unittest.py

Issue 13852011: Sort list of files that are missing OWNERS LGTM in presubmit check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/presubmit_unittest.py
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index 243c9070f07020ced507906f2e6236a6220bc43b..9051e6d505652dedf7eed69c119df116baac0f66 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -2419,9 +2419,11 @@ class CannedChecksUnittest(PresubmitTestsBase):
'brett@example.com']),
reviewers=set(['john@example.com',
'ben@example.com']),
- uncovered_files=set(['foo/xyz.cc']),
+ uncovered_files=set(['foo/xyz.cc', 'foo/bar.cc']),
expected_output='Missing LGTM from an OWNER '
- 'for these files:\n foo/xyz.cc\n',
+ 'for these files:\n'
+ ' foo/bar.cc\n'
+ ' foo/xyz.cc\n',
author_counts_as_owner=False)
def testCannedCheckOwners_TBR(self):
« no previous file with comments | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698