Fix Clang errors in the Windows screen capture code

Fix Clang errors in the Windows screen capture code

"and" and "xor" are alternate spellings of the "&&" and "^" operators,
and clang doesn't like it if you use them as identifiers.

Clang also doesn't like static_cast<> from void * to a function pointer,
but reinterpret_cast<> works.

R=alexeypa@chromium.org
BUG=82385
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195057

[alexeypa (please no reviews), 2013-04-18 18:56:03]

lgtm once my comments are addressed.

https://codereview.chromium.org/13852007/diff/1/media/video/capture/screen/sc...
File media/video/capture/screen/screen_capturer_win.cc (right):

https://codereview.chromium.org/13852007/diff/1/media/video/capture/screen/sc...
media/video/capture/screen/screen_capturer_win.cc:546: int xor_ = xor_mask[byte]
& (1 << bit);
Could you please name them |and_bit| and |xor_bit| instead?

https://codereview.chromium.org/13852007/diff/1/media/video/capture/screen/sc...
media/video/capture/screen/screen_capturer_win.cc:549: //  and_  xor_   Windows
Result  Our result   RGB  Alpha
This is a comment, so I don't think Clang cares about keywords in here. Could
you please restore AND and XOR?

https://codereview.chromium.org/13852007/diff/1/media/video/capture/screen/sc...
media/video/capture/screen/screen_capturer_win.cc:554: // Since we don't support
xor_ cursors, we replace the "Reverse Screen"
Same as above.

[Reid Kleckner, 2013-04-18 19:01:36]

Committing

https://codereview.chromium.org/13852007/diff/1/media/video/capture/screen/sc...
File media/video/capture/screen/screen_capturer_win.cc (right):

https://codereview.chromium.org/13852007/diff/1/media/video/capture/screen/sc...
media/video/capture/screen/screen_capturer_win.cc:546: int xor_ = xor_mask[byte]
& (1 << bit);
On 2013/04/18 18:56:03, alexeypa wrote:
> Could you please name them |and_bit| and |xor_bit| instead?

Done.

https://codereview.chromium.org/13852007/diff/1/media/video/capture/screen/sc...
media/video/capture/screen/screen_capturer_win.cc:549: //  and_  xor_   Windows
Result  Our result   RGB  Alpha
On 2013/04/18 18:56:03, alexeypa wrote:
> This is a comment, so I don't think Clang cares about keywords in here. Could
> you please restore AND and XOR?

Oops, yeah that was totally unintented.  :)

[commit-bot: I haz the power, 2013-04-18 19:56:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rnk@chromium.org/13852007/2002

[Reid Kleckner, 2013-04-18 20:00:04]

x

[commit-bot: I haz the power, 2013-04-18 20:03:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rnk@chromium.org/13852007/5003

[commit-bot: I haz the power, 2013-04-19 00:02:39]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-04-19 00:05:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rnk@chromium.org/13852007/5003

[commit-bot: I haz the power, 2013-04-19 03:07:10]

Change committed as 195057