Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 13851002: Add a checkbox for using the billing address for shipping (Closed)

Created:
7 years, 8 months ago by Yusuf
Modified:
7 years, 8 months ago
Reviewers:
aruslan, nilesh
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

Add a checkbox for using the billing address for shipping Adding the checkbox and the wiring necessary to properly change it when the user adds or edits a shipping address manually. BUG=222747 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193337

Patch Set 1 #

Total comments: 9

Patch Set 2 : Nit fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -8 lines) Patch
M chrome/android/java/res/layout/autofill_general_layout.xml View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java View 5 chunks +16 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogGlue.java View 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Yusuf
7 years, 8 months ago (2013-04-08 23:50:57 UTC) #1
aruslan
LGTM modulo @param and nits. https://codereview.chromium.org/13851002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java File chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java (right): https://codereview.chromium.org/13851002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java#newcode152 chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java:152: * @return The placeholder ...
7 years, 8 months ago (2013-04-09 00:10:04 UTC) #2
aruslan
https://codereview.chromium.org/13851002/diff/1/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc File chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc (right): https://codereview.chromium.org/13851002/diff/1/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc#newcode48 chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc:48: use_billing_for_shipping.obj())); On 2013/04/09 00:10:04, aruslan wrote: > +4 indent ...
7 years, 8 months ago (2013-04-09 00:10:52 UTC) #3
nilesh
LGTM https://codereview.chromium.org/13851002/diff/1/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc File chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc (right): https://codereview.chromium.org/13851002/diff/1/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc#newcode40 chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc:40: ScopedJavaLocalRef<jstring> use_billing_for_shipping = I like the variable name ...
7 years, 8 months ago (2013-04-09 00:12:53 UTC) #4
Yusuf
https://codereview.chromium.org/13851002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java File chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java (right): https://codereview.chromium.org/13851002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java#newcode152 chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java:152: * @return The placeholder string that should be shown ...
7 years, 8 months ago (2013-04-09 00:31:29 UTC) #5
aruslan
https://codereview.chromium.org/13851002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java File chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java (right): https://codereview.chromium.org/13851002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java#newcode152 chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java:152: * @return The placeholder string that should be shown ...
7 years, 8 months ago (2013-04-09 00:33:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/13851002/6001
7 years, 8 months ago (2013-04-10 00:35:33 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101491
7 years, 8 months ago (2013-04-10 02:34:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/13851002/6001
7 years, 8 months ago (2013-04-10 05:43:45 UTC) #9
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 06:41:12 UTC) #10
Message was sent while issue was closed.
Change committed as 193337

Powered by Google App Engine
This is Rietveld 408576698