Add a checkbox for using the billing address for shipping

Add a checkbox for using the billing address for shipping

Adding the checkbox and the wiring necessary to properly change it when
the user adds or edits a shipping address manually.

BUG=222747
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193337

[aruslan, 2013-04-09 00:10:04]

LGTM modulo @param and nits.

https://codereview.chromium.org/13851002/diff/1/chrome/android/java/src/org/c...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java
(right):

https://codereview.chromium.org/13851002/diff/1/chrome/android/java/src/org/c...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java:152:
* @return The placeholder string that should be shown on the field.
@param useBillingForShippingText

https://codereview.chromium.org/13851002/diff/1/chrome/browser/ui/android/aut...
File chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc (right):

https://codereview.chromium.org/13851002/diff/1/chrome/browser/ui/android/aut...
chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc:42:
env,controller_->UseBillingForShippingText());
space after the comma.

https://codereview.chromium.org/13851002/diff/1/chrome/browser/ui/android/aut...
chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc:48:
use_billing_for_shipping.obj()));
+4 indent

[aruslan, 2013-04-09 00:10:52]

https://codereview.chromium.org/13851002/diff/1/chrome/browser/ui/android/aut...
File chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc (right):

https://codereview.chromium.org/13851002/diff/1/chrome/browser/ui/android/aut...
chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc:48:
use_billing_for_shipping.obj()));
On 2013/04/09 00:10:04, aruslan wrote:
> +4 indent

scratch that, long day.

[nilesh, 2013-04-09 00:12:53]

LGTM

https://codereview.chromium.org/13851002/diff/1/chrome/browser/ui/android/aut...
File chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc (right):

https://codereview.chromium.org/13851002/diff/1/chrome/browser/ui/android/aut...
chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc:40:
ScopedJavaLocalRef<jstring> use_billing_for_shipping =
I like the variable name you have used in java.
use_billing_for_shipping_text

[Yusuf, 2013-04-09 00:31:29]

https://codereview.chromium.org/13851002/diff/1/chrome/android/java/src/org/c...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java
(right):

https://codereview.chromium.org/13851002/diff/1/chrome/android/java/src/org/c...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java:152:
* @return The placeholder string that should be shown on the field.
I think this javadoc is for the API call, not the constructor. The constructor
was left without a javadoc because it is protected, I believe.

On 2013/04/09 00:10:04, aruslan wrote:
> @param useBillingForShippingText

https://codereview.chromium.org/13851002/diff/1/chrome/browser/ui/android/aut...
File chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc (right):

https://codereview.chromium.org/13851002/diff/1/chrome/browser/ui/android/aut...
chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc:40:
ScopedJavaLocalRef<jstring> use_billing_for_shipping =
On 2013/04/09 00:12:54, nilesh wrote:
> I like the variable name you have used in java.
> use_billing_for_shipping_text

Done.

https://codereview.chromium.org/13851002/diff/1/chrome/browser/ui/android/aut...
chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc:42:
env,controller_->UseBillingForShippingText());
On 2013/04/09 00:10:04, aruslan wrote:
> space after the comma.

Done.

[aruslan, 2013-04-09 00:33:08]

https://codereview.chromium.org/13851002/diff/1/chrome/android/java/src/org/c...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java
(right):

https://codereview.chromium.org/13851002/diff/1/chrome/android/java/src/org/c...
chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java:152:
* @return The placeholder string that should be shown on the field.
On 2013/04/09 00:31:29, Yusuf wrote:
> I think this javadoc is for the API call, not the constructor. The constructor
> was left without a javadoc because it is protected, I believe.
> 
> On 2013/04/09 00:10:04, aruslan wrote:
> > @param useBillingForShippingText
> 

Argh :) Ship it!

[commit-bot: I haz the power, 2013-04-10 00:35:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusufo@chromium.org/13851002/6001

[commit-bot: I haz the power, 2013-04-10 02:34:18]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-04-10 05:43:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusufo@chromium.org/13851002/6001

[commit-bot: I haz the power, 2013-04-10 06:41:12]

Change committed as 193337