Issue 13849012: We need to call aura::Window::Show from the DesktopNativeWidgetAura::ShowMaximizedWithBounds and Sh…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13849012: We need to call aura::Window::Show from the DesktopNativeWidgetAura::ShowMaximizedWithBounds and Sh… (Closed)

Created:
7 years, 8 months ago by ananta

Modified:
7 years, 8 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

We need to call aura::Window::Show from the DesktopNativeWidgetAura::ShowMaximizedWithBounds and ShowWithWindowState functions. This is specifically important if the underlying Widget was hidden and then made visible via Widget::Show. The visibility state of the aura Window object remains as hidden, which results in the compositor not painting this window. Fixes bug http://code.google.com/p/chromium/issues/detail?id=229913 where the composited panel window would turn black on Windows 8 if we switched to the metro screen and back. R=ben@chromium.org BUG=229913 TEST=Covered by new views unit test TestWindowVisibilityAfterHide Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195270

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	ui/views/widget/desktop_aura/desktop_native_widget_aura.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	ui/views/widget/widget_unittest.cc	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/13849012/1

7 years, 8 months ago (2013-04-19 17:52:14 UTC) #3

Message was sent while issue was closed.

Change committed as 195270

Expand Messages | Collapse Messages