Fix so that you can run presubmit.py in Windows.

Fix so that you can run presubmit.py in Windows.
presubmit.py tried to execute cpplint.py directly, but in Windows it's the shell that connects that to the python binary so the execution (subprocess.Popen) needs to be told how to find python. An alternative would be to call subprocess.Popen with shell=True but this is less dangerous.

Committed: https://code.google.com/p/v8/source/detail?r=14263

[Daniel Bratell, 2013-04-11 11:48:10]

Fix so that you can run presubmit.py in Windows.
presubmit.py tried to execute cpplint.py directly, but in Windows it's the shell
that connects that to the python binary so the execution (subprocess.Popen)
needs to be told how to find python. An alternative would be to call
subprocess.Popen with shell=True but this is less dangerous.

This is my first patch so please let me know if I do something wrong.

[Yang, 2013-04-11 12:25:22]

On 2013/04/11 11:48:10, bratell wrote:
> Fix so that you can run presubmit.py in Windows.
> presubmit.py tried to execute cpplint.py directly, but in Windows it's the
shell
> that connects that to the python binary so the execution (subprocess.Popen)
> needs to be told how to find python. An alternative would be to call
> subprocess.Popen with shell=True but this is less dangerous.
> 
> This is my first patch so please let me know if I do something wrong.

This doesn't seem to work on on Linux workstation for some reason.

[Daniel Bratell, 2013-04-11 15:33:05]

> This doesn't seem to work on on Linux workstation for some reason.

Paths... The code used subprocess.Popen's "search through the path" for the
first argument. Now when cpplint.py is the second argument the code needs to
locate it by hand (would have been a oneliner in Python 3.3 apparently).

[Yang, 2013-04-15 12:18:23]

On 2013/04/11 15:33:05, bratell wrote:
> > This doesn't seem to work on on Linux workstation for some reason.
> 
> Paths... The code used subprocess.Popen's "search through the path" for the
> first argument. Now when cpplint.py is the second argument the code needs to
> locate it by hand (would have been a oneliner in Python 3.3 apparently).

Very nice. Thanks! LGTM.

[Yang, 2013-04-15 12:21:12]

Committed patchset #2 manually as r14263 (presubmit successful).

[Daniel Bratell, 2013-04-15 12:40:04]

On 2013/04/15 12:21:12, Yang wrote:
> Committed patchset #2 manually as r14263 (presubmit successful).

Thanks a lot for your help!