|
Allow showing pending URL for new tab navigations, but only if safe.
We revert to showing the opener's URL if it modifies the content of the
initial blank page before the pending URL commits, to prevent URL spoofs.
Implications:
- All renderer-initiated navigations now have pending NavigationEntries.
- GetURL and GetTitle use the visible entry, not active entry.
- The renderer notifies the browser if DOM mutations occur before first load.
[Second attempt, after http://crrev.com/191277 was reverted.]
BUG= 9682
TEST=Open a slow link in a new tab. Destination URL should be visible and reloadable.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195553
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+409 lines, -45 lines) |
Patch |
|
M |
chrome/browser/external_extension_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/managed_mode/managed_mode_browsertest.cc
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/browser_navigator_browsertest.cc
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/constrained_window_views_browsertest.cc
|
View
|
|
2 chunks |
+11 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/android/content_view_core_impl.cc
|
View
|
|
1 chunk |
+6 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/render_view_host_delegate.h
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/render_view_host_impl.h
|
View
|
|
3 chunks |
+14 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/render_view_host_impl.cc
|
View
|
|
4 chunks |
+12 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/render_view_host_manager_browsertest.cc
|
View
|
|
1 chunk |
+86 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/web_contents/navigation_controller_impl.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/web_contents/navigation_controller_impl.cc
|
View
|
|
7 chunks |
+59 lines, -20 lines |
0 comments
|
Download
|
|
M |
content/browser/web_contents/navigation_controller_impl_unittest.cc
|
View
|
|
8 chunks |
+114 lines, -20 lines |
0 comments
|
Download
|
|
M |
content/browser/web_contents/web_contents_impl.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/web_contents/web_contents_impl.cc
|
View
|
|
5 chunks |
+31 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/common/view_messages.h
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/renderer/render_view_impl.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
content/renderer/render_view_impl.cc
|
View
|
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
|
A |
content/test/data/click-nocontent-link.html
|
View
|
|
1 chunk |
+46 lines, -0 lines |
0 comments
|
Download
|
Total messages: 5 (0 generated)
|