net/third_party/nss/ssl/ssl3con.c - Issue 13843023: Use CERT_GetCertKeyType to get KeyType for ssl3_PlatformSignHashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/third_party/nss/ssl/ssl3con.c

Issue 13843023: Use CERT_GetCertKeyType to get KeyType for ssl3_PlatformSignHashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed code review comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/third_party/nss/ssl/ssl3con.c

diff --git a/net/third_party/nss/ssl/ssl3con.c b/net/third_party/nss/ssl/ssl3con.c

index 18ed5395c8ff674d4d1a92f3cf87fe865f85a56e..20d14833890ccdaf32e3dda94e3e21bbdbe32364 100644

--- a/net/third_party/nss/ssl/ssl3con.c

+++ b/net/third_party/nss/ssl/ssl3con.c

@@ -5365,8 +5365,9 @@ ssl3_SendCertificateVerify(sslSocket *ss)

isTLS = (PRBool)(ss->ssl3.pwSpec->version > SSL_LIBRARY_VERSION_3_0);

if (ss->ssl3.platformClientKey) {

#ifdef NSS_PLATFORM_CLIENT_AUTH

- rv = ssl3_PlatformSignHashes(&hashes, ss->ssl3.platformClientKey,

- &buf, isTLS);

+ rv = ssl3_PlatformSignHashes(

+ &hashes, ss->ssl3.platformClientKey, &buf, isTLS,

+ CERT_GetCertKeyType(&ss->ssl3.clientCertificate->subjectPublicKeyInfo));

ssl_FreePlatformKey(ss->ssl3.platformClientKey);

ss->ssl3.platformClientKey = (PlatformKey)NULL;

#endif /* NSS_PLATFORM_CLIENT_AUTH */

« no previous file with comments | « no previous file | net/third_party/nss/ssl/sslimpl.h » ('j') | no next file with comments »