Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 13843008: Remove the --disable-javascript-i18n-api command line flag. (Closed)

Created:
7 years, 8 months ago by Peter Beverloo
Modified:
7 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Remove the --disable-javascript-i18n-api command line flag. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210947

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
lgtm
7 years, 8 months ago (2013-04-23 13:30:40 UTC) #1
Peter Beverloo
For reference and discussion: https://codereview.chromium.org/13725007/ Blink-sided patch (which depends on this for the plumbing): https://codereview.chromium.org/14429004/ ...
7 years, 8 months ago (2013-04-23 13:33:26 UTC) #2
Peter Beverloo
Darin, would you have a second to rubberstamp this as you're an owner in all ...
7 years, 8 months ago (2013-04-23 13:39:06 UTC) #3
Nebojša Ćirić
On 2013/04/23 13:39:06, Peter Beverloo wrote: > Darin, would you have a second to rubberstamp ...
7 years, 8 months ago (2013-04-23 16:01:49 UTC) #4
darin (slow to review)
LGTM
7 years, 8 months ago (2013-04-23 20:56:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/13843008/7001
7 years, 5 months ago (2013-07-10 16:44:40 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-10 22:05:59 UTC) #7
Message was sent while issue was closed.
Change committed as 210947

Powered by Google App Engine
This is Rietveld 408576698