Make git-cl accepts multiple --reviewers and --cc arguments.

Make git-cl accepts multiple --reviewers and --cc arguments.

It makes sure the resulting options.reviewers and options.cc are internally
consistent by splitting comma separated items.

R=iannucci@chromium.org
BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=193496

[M-A Ruel, 2013-04-09 04:37:14]

This CL enforces options.reviewers to be a list and sanitizes it. It will make
the code managing reviewers easier to read since reviewers will always be a
list.

[M-A Ruel, 2013-04-10 17:11:22]

On 2013/04/09 04:37:14, Marc-Antoine Ruel wrote:
> This CL enforces options.reviewers to be a list and sanitizes it. It will make
> the code managing reviewers easier to read since reviewers will always be a
> list.

Ping, I'd like to get the whole thing in before EOD if possible.

[Dirk Pranke, 2013-04-10 19:55:46]

lgtm w/ slightly annoying nit (yes, I realize this makes splitting harder).

https://codereview.chromium.org/13843002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/13843002/diff/1/git_cl.py#newcode1110
git_cl.py:1110: change_desc = ChangeDescription(log_desc,
','.join(options.reviewers))
Nit: ', ' (with a space) might be more readable?

[M-A Ruel, 2013-04-10 20:32:07]

https://codereview.chromium.org/13843002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/13843002/diff/1/git_cl.py#newcode1110
git_cl.py:1110: change_desc = ChangeDescription(log_desc,
','.join(options.reviewers))
On 2013/04/10 19:55:46, Dirk Pranke wrote:
> Nit: ', ' (with a space) might be more readable?

Done but it had implications, ptal.

[Dirk Pranke, 2013-04-10 23:13:02]

On 2013/04/10 20:32:07, Marc-Antoine Ruel wrote:
> https://codereview.chromium.org/13843002/diff/1/git_cl.py
> File git_cl.py (right):
> 
> https://codereview.chromium.org/13843002/diff/1/git_cl.py#newcode1110
> git_cl.py:1110: change_desc = ChangeDescription(log_desc,
> ','.join(options.reviewers))
> On 2013/04/10 19:55:46, Dirk Pranke wrote:
> > Nit: ', ' (with a space) might be more readable?
> 
> Done but it had implications, ptal.

lgtm. using strip() is better than what I had been thinking of. thanks!

[commit-bot: I haz the power, 2013-04-10 23:14:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/13843002/9001

[commit-bot: I haz the power, 2013-04-10 23:17:13]

Change committed as 193496