Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 13841012: Add asserts to String::GetFlatContent. (Closed)

Created:
7 years, 8 months ago by Yang
Modified:
7 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Add asserts to String::GetFlatContent. R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14776

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -20 lines) Patch
M src/json-stringifier.h View 3 chunks +12 lines, -11 lines 0 comments Download
M src/objects.cc View 4 chunks +5 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 5 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Toon Verwaest
lgtm
7 years, 7 months ago (2013-05-23 08:02:21 UTC) #1
Yang
7 years, 7 months ago (2013-05-23 13:53:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r14776 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698