Asynchronous initialization in Simple Index.

net/disk_cache/simple/simple_backend_impl.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_DISK_CACHE_SIMPLE_SIMPLE_BACKEND_IMPL_H_
 #define NET_DISK_CACHE_SIMPLE_SIMPLE_BACKEND_IMPL_H_
 
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/files/file_path.h"
 #include "base/task_runner.h"
 #include "net/base/cache_type.h"
 #include "net/disk_cache/disk_cache.h"
 
+namespace base {
+class MessageLoopProxy;
+}
+
 namespace disk_cache {
 
 // SimpleBackendImpl is a new cache backend that stores entries in individual
 // files.
 
 // It is currently a work in progress, missing many features of a real cache,
 // such as eviction.
 
 // See http://www.chromium.org/developers/design-documents/network-stack/disk-cache/very-simple-backend
 
 class SimpleIndex;
 
 class NET_EXPORT_PRIVATE SimpleBackendImpl : public Backend {
  public:
   SimpleBackendImpl(const base::FilePath& path, int max_bytes,
                     net::CacheType type,
                     const scoped_refptr<base::TaskRunner>& cache_thread,
                     net::NetLog* net_log);
 
-  int Init(const CompletionCallback& callback);
+  int Init(const CompletionCallback& completition_callback);

[gavinp, 2013/04/11 09:56:32]

Nit: spelling (in the method too).

[felipeg, 2013/04/11 11:25:45]

Done.

 
   virtual ~SimpleBackendImpl();
 
   // From Backend:
   virtual net::CacheType GetCacheType() const OVERRIDE;
   virtual int32 GetEntryCount() const OVERRIDE;
   virtual int OpenEntry(const std::string& key, Entry** entry,
                         const CompletionCallback& callback) OVERRIDE;
   virtual int CreateEntry(const std::string& key, Entry** entry,
                           const CompletionCallback& callback) OVERRIDE;
   virtual int DoomEntry(const std::string& key,
                         const CompletionCallback& callback) OVERRIDE;
   virtual int DoomAllEntries(const CompletionCallback& callback) OVERRIDE;
   virtual int DoomEntriesBetween(base::Time initial_time,
                                  base::Time end_time,
                                  const CompletionCallback& callback) OVERRIDE;
   virtual int DoomEntriesSince(base::Time initial_time,
                                const CompletionCallback& callback) OVERRIDE;
   virtual int OpenNextEntry(void** iter, Entry** next_entry,
                             const CompletionCallback& callback) OVERRIDE;
   virtual void EndEnumeration(void** iter) OVERRIDE;
   virtual void GetStats(
       std::vector<std::pair<std::string, std::string> >* stats) OVERRIDE;
   virtual void OnExternalCacheHit(const std::string& key) OVERRIDE;
 
  private:
-  // Must run on Cache Thread.
-  void InitializeIndex(base::MessageLoopProxy* io_thread,
-                       const CompletionCallback& callback);
+  typedef base::Callback<void(int)> InitializeIndexCallback;

[gavinp, 2013/04/11 09:56:32]

How about naming the int? Call it "result" or io_result.

[felipeg, 2013/04/11 11:25:45]

Done.

+
+  void InitializeIndex(const CompletionCallback& callback, int rv);

[pasko-google - do not use, 2013/04/10 17:51:01]

Should probably comment that this should run on the IO thread.

[felipeg, 2013/04/11 09:41:35]

Done.

[gavinp, 2013/04/11 09:56:32]

Does every method on this class now run on the IO thread, or are there still
cache thread holdovers?

[gavinp, 2013/04/11 09:56:32]

rv isn't a good name for an  argument; it's more typically an automatic that is
going to be returned. Call it "result" or "io_result" instead?

[felipeg, 2013/04/11 11:25:45]

Done.

+
+  static void CreateDirectory(

[pasko-google - do not use, 2013/04/10 17:51:01]

I would rather call it EnsureDirectoryConsistent(), there will be a little more
checking shortly..

Should comment that this runs on the cache thread.

[felipeg, 2013/04/11 09:41:35]

Done.

+      base::MessageLoopProxy* io_thread,
+      const base::FilePath& path,
+      const InitializeIndexCallback& initialize_index_callback);
 
   const base::FilePath path_;
-
   scoped_ptr<SimpleIndex> index_;
   const scoped_refptr<base::TaskRunner> cache_thread_;
 };
 
 }  // namespace disk_cache
 
 #endif  // NET_DISK_CACHE_SIMPLE_SIMPLE_BACKEND_IMPL_H_