Issue 13833003: drive: Pass SHARED_WITH_ME search type to SearchMetadata()

Issue 13833003: drive: Pass SHARED_WITH_ME search type to SearchMetadata() (Closed)

Created:
7 years, 8 months ago by Haruki Sato

Modified:
7 years, 8 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Pass SHARED_WITH_ME search type to SearchMetadata() BUG=224186 TEST=unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193372

Patch Set 1 : #

Total comments: 2

Patch Set 2 : add else DCHECK #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View	1	1 chunk	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Haruki Sato

Both JS side and C++ side support SHARED_WITH_ME search type. Thanks.

7 years, 8 months ago (2013-04-10 09:15:48 UTC) #1

hashimoto

Please update file_browser_private.json to accept "SHARED_WITH_ME" as a type. https://codereview.chromium.org/13833003/diff/2001/chrome/browser/chromeos/extensions/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right): https://codereview.chromium.org/13833003/diff/2001/chrome/browser/chromeos/extensions/file_browser_private_api.cc#newcode3072 chrome/browser/chromeos/extensions/file_browser_private_api.cc:3072: ...

7 years, 8 months ago (2013-04-10 09:32:40 UTC) #2

Haruki Sato

Thanks. file_browser_private.json is updated in https://codereview.chromium.org/13913009/. https://codereview.chromium.org/13833003/diff/2001/chrome/browser/chromeos/extensions/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right): https://codereview.chromium.org/13833003/diff/2001/chrome/browser/chromeos/extensions/file_browser_private_api.cc#newcode3072 chrome/browser/chromeos/extensions/file_browser_private_api.cc:3072: options = drive::SEARCH_METADATA_SHARED_WITH_ME; ...

7 years, 8 months ago (2013-04-10 09:43:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/13833003/6001

7 years, 8 months ago (2013-04-10 10:21:28 UTC) #5

Message was sent while issue was closed.

Change committed as 193372

Expand Messages | Collapse Messages