Issue 13831013: Don't include forms without fields in has_more_forms calculation.

Issue 13831013: Don't include forms without fields in has_more_forms calculation. (Closed)

Created:
7 years, 8 months ago by Dane Wallinga

Modified:
7 years, 7 months ago

Reviewers:
Raman Kakilate, ahutter, Ilya Sherman

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Don't include forms without fields in has_more_forms calculation. BUG=233788 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197793

Patch Set 1 #

Patch Set 2 : Add some test coverage #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -1 line)			Patch
	M	chrome/renderer/autofill/form_autofill_browsertest.cc	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
	M	components/autofill/renderer/form_cache.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Dane Wallinga

@ramankk,isherman - not horribly urgent, but please take a glance when you have a chance.

7 years, 8 months ago (2013-04-24 18:28:53 UTC) #1

Dane Wallinga

On 2013/04/25 04:49:15, Ilya Sherman wrote: > Can you add test coverage? Otherwise LGTM. Will ...

7 years, 8 months ago (2013-04-25 18:41:39 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgwallinga@chromium.org/13831013/6001

7 years, 7 months ago (2013-05-01 20:56:04 UTC) #6

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 7 months ago (2013-05-01 21:19:05 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgwallinga@chromium.org/13831013/6001

7 years, 7 months ago (2013-05-01 21:54:48 UTC) #8

Message was sent while issue was closed.

Change committed as 197793

Expand Messages | Collapse Messages