Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 13831008: Fixing RenderViewImpl constructor initializers ordering. (Closed)

Created:
7 years, 8 months ago by nasko
Modified:
7 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fixing RenderViewImpl constructor initializers ordering. The problem is that one of the variables was incorrectly placed in the android ifdef. Also, moving the plugins specific section before Misc. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195177

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M content/renderer/render_view_impl.h View 2 chunks +14 lines, -12 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nasko
Hey guys, Can you review this fix in the constructor initialization? Thanks, Nasko
7 years, 8 months ago (2013-04-18 17:39:21 UTC) #1
Charlie Reis
LGTM. nilesh, can you confirm that load_progress_tracker_ should only be initialized in Android builds? Looks ...
7 years, 8 months ago (2013-04-18 17:43:34 UTC) #2
kmadhusu
lgtm. Thanks,
7 years, 8 months ago (2013-04-18 17:54:25 UTC) #3
nilesh
On 2013/04/18 17:43:34, creis wrote: > LGTM. nilesh, can you confirm that load_progress_tracker_ should only ...
7 years, 8 months ago (2013-04-18 18:14:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/13831008/1
7 years, 8 months ago (2013-04-18 18:15:55 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30294
7 years, 8 months ago (2013-04-18 22:05:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/13831008/1
7 years, 8 months ago (2013-04-19 13:27:58 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 14:24:47 UTC) #8
Message was sent while issue was closed.
Change committed as 195177

Powered by Google App Engine
This is Rietveld 408576698