BrowserTest for VariationsRestrictParameter user policy

Browser test for the VariationsService's support of the VariationsRestrictParameter user policy.

Applies to all platforms except ChromeOS, which uses a device policy.

BUG=232881
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194957

[Mathieu, 2013-04-18 14:40:35]

Hi all, 

This is a test for the user policy for all platforms except ChromeOS. Please
take a look.

[Alexei Svitkine (slow), 2013-04-18 14:53:23]

LGTM with a comment

https://codereview.chromium.org/13831007/diff/2001/chrome/browser/policy/poli...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/13831007/diff/2001/chrome/browser/policy/poli...
chrome/browser/policy/policy_browsertest.cc:2065: virtual
~PolicyVariationsServiceTest() {}
You don't need these two, since the class is defined only in the .cc file.

[Mathieu, 2013-04-18 14:56:39]

https://codereview.chromium.org/13831007/diff/2001/chrome/browser/policy/poli...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/13831007/diff/2001/chrome/browser/policy/poli...
chrome/browser/policy/policy_browsertest.cc:2065: virtual
~PolicyVariationsServiceTest() {}
On 2013/04/18 14:53:23, Alexei Svitkine wrote:
> You don't need these two, since the class is defined only in the .cc file.

Done.

[Mattias Nissler (ping if slow), 2013-04-18 15:02:53]

LGTM, one suggestion that you may choose to ignore.

https://codereview.chromium.org/13831007/diff/2001/chrome/browser/policy/poli...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/13831007/diff/2001/chrome/browser/policy/poli...
chrome/browser/policy/policy_browsertest.cc:2087:
g_browser_process->local_state()).spec());
Ideally, you'd check the URL that the service uses when making its request. Not
sure how practical that is here, so your call.

[commit-bot: I haz the power, 2013-04-18 15:15:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mathp@chromium.org/13831007/6001

[Mathieu, 2013-04-18 15:16:25]

Thanks!

https://codereview.chromium.org/13831007/diff/2001/chrome/browser/policy/poli...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/13831007/diff/2001/chrome/browser/policy/poli...
chrome/browser/policy/policy_browsertest.cc:2087:
g_browser_process->local_state()).spec());
On 2013/04/18 15:02:53, Mattias Nissler wrote:
> Ideally, you'd check the URL that the service uses when making its request.
Not
> sure how practical that is here, so your call.

In this case this function is directly setting the member variable
|variations_server_url_|, which is used in the fetch, so I will leave it like
that.

[commit-bot: I haz the power, 2013-04-18 17:23:08]

Change committed as 194957