Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 13831004: Allow multiple OSes to be checked out with git submodules. (Closed)

Created:
7 years, 8 months ago by Torne
Modified:
7 years, 8 months ago
Reviewers:
szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Allow multiple OSes to be checked out with git submodules. Allow target.os to be a multivalue config option, which will cause submodules required by any of the listed OSes to be checked out. You can add additional OSes to the list with "git config --add target.os". BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=193901

Patch Set 1 #

Total comments: 2

Patch Set 2 : address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M crup-runner.sh View 1 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Torne
Hi Stefan, I wanted to be able to build linux and android chromium from the ...
7 years, 8 months ago (2013-04-11 10:10:07 UTC) #1
szager1
lgtm with small change. Thanks! https://codereview.chromium.org/13831004/diff/1/crup-runner.sh File crup-runner.sh (right): https://codereview.chromium.org/13831004/diff/1/crup-runner.sh#newcode68 crup-runner.sh:68: if [ "$update_policy" == ...
7 years, 8 months ago (2013-04-11 17:26:03 UTC) #2
Torne
https://codereview.chromium.org/13831004/diff/1/crup-runner.sh File crup-runner.sh (right): https://codereview.chromium.org/13831004/diff/1/crup-runner.sh#newcode68 crup-runner.sh:68: if [ "$update_policy" == checkout ]; then 2013/04/11 17:26:03, ...
7 years, 8 months ago (2013-04-12 10:04:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/13831004/4001
7 years, 8 months ago (2013-04-12 10:04:59 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-12 10:06:48 UTC) #5
Message was sent while issue was closed.
Change committed as 193901

Powered by Google App Engine
This is Rietveld 408576698