Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 13828003: [Android] Build gtest APKs like other APKs (Closed)

Created:
7 years, 8 months ago by cjhopman
Modified:
7 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

[Android] Build gtest APKs like other APKs After much work, we can build gtest APKs without first transforming .java files, resource files, or the AndroidManifest.xml. We can directly use java_apk.gypi and build like all other APKs. Do that. Also, native_test_apk.xml was the last user of common.xml and sdk-targets.xml, and so those can now be removed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193576

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -718 lines) Patch
D build/android/ant/common.xml View 1 chunk +0 lines, -92 lines 0 comments Download
D build/android/ant/sdk-targets.xml View 1 chunk +0 lines, -278 lines 0 comments Download
M build/apk_test.gypi View 2 chunks +2 lines, -45 lines 0 comments Download
M testing/android/README.chromium View 1 chunk +2 lines, -3 lines 0 comments Download
D testing/android/generate_native_test.py View 1 chunk +0 lines, -202 lines 0 comments Download
D testing/android/native_test_apk.xml View 1 chunk +0 lines, -87 lines 0 comments Download
D testing/android/res/values/strings.xml View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
cjhopman
7 years, 8 months ago (2013-04-10 01:11:23 UTC) #1
Yaron
https://codereview.chromium.org/13828003/diff/1/build/apk_test.gypi File build/apk_test.gypi (right): https://codereview.chromium.org/13828003/diff/1/build/apk_test.gypi#newcode33 build/apk_test.gypi:33: 'java_in_dir': '<(DEPTH)/testing/android/java', Looks like this would recompile once for ...
7 years, 8 months ago (2013-04-10 01:35:57 UTC) #2
cjhopman
https://codereview.chromium.org/13828003/diff/1/build/apk_test.gypi File build/apk_test.gypi (right): https://codereview.chromium.org/13828003/diff/1/build/apk_test.gypi#newcode33 build/apk_test.gypi:33: 'java_in_dir': '<(DEPTH)/testing/android/java', On 2013/04/10 01:35:57, Yaron wrote: > Looks ...
7 years, 8 months ago (2013-04-10 23:24:03 UTC) #3
Yaron
lgtm I'm assuming you'll take care of cleaning up native_lib_target in a follow up..
7 years, 8 months ago (2013-04-10 23:49:47 UTC) #4
Yaron
By which I mean input_shlib_path :)
7 years, 8 months ago (2013-04-10 23:50:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13828003/5001
7 years, 8 months ago (2013-04-11 02:11:15 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-11 04:47:11 UTC) #7
Message was sent while issue was closed.
Change committed as 193576

Powered by Google App Engine
This is Rietveld 408576698