components/content_settings/core/browser/website_settings_registry.cc - Issue 1382783002: Store USB device permissions in website settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/website_settings_registry.cc

Issue 1382783002: Store USB device permissions in website settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/usb/web_usb_permission_store.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | components/content_settings/core/common/content_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/website_settings_registry.cc

diff --git a/components/content_settings/core/browser/website_settings_registry.cc b/components/content_settings/core/browser/website_settings_registry.cc

index f0e9e1549c3b22d932418727340d5881b2e1ca51..db4a11d8dc9d503461bd333dcf7c0c2fae8633d1 100644

--- a/components/content_settings/core/browser/website_settings_registry.cc

+++ b/components/content_settings/core/browser/website_settings_registry.cc

@@ -88,6 +88,8 @@ void WebsiteSettingsRegistry::Init() {

WebsiteSettingsInfo::UNSYNCABLE, WebsiteSettingsInfo::LOSSY);

+ Register(CONTENT_SETTINGS_TYPE_USB, "usb", nullptr,

+ WebsiteSettingsInfo::UNSYNCABLE, WebsiteSettingsInfo::LOSSY);

raymes 2015/10/01 01:28:19 You won't want this to be lossy

raymes 2015/10/01 01:28:19 I think you should also register a content setting

}

} // namespace content_settings

« chrome/browser/usb/web_usb_permission_store.cc ('K') | « chrome/chrome_tests_unit.gypi ('k') | components/content_settings/core/common/content_settings.cc » ('j') | no next file with comments »