[GN] Add a template which wraps generate_test_lists.py.

chromecast/BUILD.gn

Index: chromecast/BUILD.gn
diff --git a/chromecast/BUILD.gn b/chromecast/BUILD.gn
index f5712fe406d6b97d443c2c39302d6dad9c06e79e..98a86d940a600ad0a668f787f5cf6aa955aa5d56 100644
--- a/chromecast/BUILD.gn
+++ b/chromecast/BUILD.gn
@@ -2,10 +2,10 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//chromecast/build/tests/cast_test.gni")
 import("//chromecast/chromecast.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
-import("//testing/test.gni")
 import("//tools/grit/repack.gni")
 import("//ui/ozone/ozone.gni")
 
@@ -33,17 +33,114 @@ component("chromecast") {
   ]
 }
 
-group("chromecast_unittests") {
-  testonly = true
-
-  deps = [
-    # TODO(slan): Get this target building and comment it in.
-    # "//chromecast/app:cast_shell_unittests",
+# A list of all public test() binaries. This is an organizational target that
+# cannot be built directly.

[mbjorge, 2015/10/01 17:11:40]

Can you add a note here that also says which target I should be trying to build
if I want to make/run the tests (e.g. "See cast_test_lists below")? Or maybe
switch the order and put the buildable/runnable target first?

[slan, 2015/10/01 20:08:03]

Done.

+cast_test_group("cast_tests") {

[alokp, 2015/10/01 13:13:46]

If both of these templates are only being used once, why do you need a template?
Do you expect to use them in internal code as well?

[slan, 2015/10/01 14:08:56]

Exactly. There will be 2 cast_test_group()s: one for external tests and one for
internal tests. And while there will only be one cast_group_test_list, that
object requires knowledge of the implicit targets created for each
cast_test_group, so it makes sense to define it in this .gni. Here is the
internal CL for reference:

https://eureka-internal-review.git.corp.google.com/#/c/39533/

+  tests = [
+    "//base:base_unittests",
     "//chromecast/base:cast_base_unittests",
     "//chromecast/crypto:cast_crypto_unittests",
     "//chromecast/crash:cast_crash_unittests",
-    "//chromecast/media:cast_media_unittests",
+    "//content/content_unittests",

[mbjorge, 2015/10/01 17:11:40]

Is this target supposed to be //content/test:content_unittests?

[slan, 2015/10/01 20:08:03]

Yes, added a mechanism to ensure that the target names are valid.

+    "//crypto:crypto_unittests",
+    "//ipc:ipc_tests",
+    "//jingle:jingle_unittests",
+    "//media:media_unittests",
+    "//media/midi:midi_unittests",
+    "//net:net_unittests",
+    "//ppapi/ppapi_internal:ppapi_unittests",
+    "//sandbox:sandbox_linux_unittests",
+    "//sql:sql_unittests",
+    "//sync:sync_unit_tests",
+    "//third_party/cacheinvalidation:cacheinvalidation_unittests",
+    "//ui/base:ui_base_unittests",
+    "//url:url_unittests",
   ]
+
+  filters = []
+
+  if (target_cpu == "arm" && target_os == "linux") {

[mbjorge, 2015/10/01 17:11:39]

I like the filters being here. I don't think it would make sense to put them
elsewhere.

[slan, 2015/10/01 20:08:03]

Agreed.

+    filters += [
+      # Run net_unittests first to avoid random failures due to slow python startup
+      # KeygenHandlerTest.SmokeTest and KeygenHandlerTest.ConcurrencyTest fail due to
+      # readonly certdb (b/8153161)
+      # URLRequestTestHTTP.GetTest_ManyCookies takes roughly 55s to run. Increase
+      # timeout to 90s from 45s to allow it to pass (b/19821476)
+      # ProxyScriptFetcherImplTest.HttpMimeType is flaking (b/19848784)
+      # Running a batch of net_unittests has high overhead. Run tests in batches of 25 to reduce number of batches (b/23156294).
+      "net_unittests --gtest_filter=-KeygenHandlerTest.SmokeTest:KeygenHandlerTest.ConcurrencyTest:ProxyScriptFetcherImplTest.HttpMimeType --test-launcher-timeout=90000 --test-launcher-batch-limit=25",
+
+      # Disable ProcessMetricsTest.GetNumberOfThreads (b/15610509)
+      # Disable ProcessUtilTest.* (need to define OS_ANDROID)
+      # Disable StackContainer.BufferAlignment (don't support 16-byte alignment)
+      # Disable SystemMetrics2Test.GetSystemMemoryInfo (buffers>0 can't be guaranteed)
+      "base_unittests --gtest_filter=-ProcessMetricsTest.GetNumberOfThreads:ProcessUtilTest.*:StackContainer.BufferAlignment:SystemMetrics2Test.GetSystemMemoryInfo",
+
+      # DesktopCaptureDeviceTest.*: No capture device on Eureka
+      # Disable PepperGamepadHostTest.WaitForReply (pepper not supported on Eureka)
+      # Disable GpuDataManagerImplPrivateTest.SetGLStrings and
+      # RenderWidgetHostTest.Background because we disable the blacklist to enable WebGL (b/16142554)
+      "content_unittests --gtest_filter=-DOMStorageDatabaseTest.TestCanOpenAndReadWebCoreDatabase:DesktopCaptureDeviceTest.Capture:GamepadProviderTest.PollingAccess:GpuDataManagerImplPrivateTest.SetGLStrings:PepperGamepadHostTest.WaitForReply:RenderWidgetHostTest.Background",
+
+      # Disable VP9 related tests (b/18593324)
+      #   PipelineIntegrationTest.BasicPlayback_MediaSource_VP9_WebM
+      #   PipelineIntegrationTest.BasicPlayback_VideoOnly_VP9_WebM
+      #   PipelineIntegrationTest.BasicPlayback_VP9*
+      #   PipelineIntegrationTest.P444_VP9_WebM
+      # Disable VP8A tests (b/18593324)
+      #   PipelineIntegrationTest.BasicPlayback_VP8A*
+      # Disable OpusAudioDecoderTest/AudioDecoderTest.ProduceAudioSamples/0 (unit
+      # test fails when Opus decoder uses fixed-point)
+      # Due to b/16456550, disable the following four test cases:
+      #   AudioOutputControllerTest.PlayDivertSwitchDeviceRevertClose
+      #   AudioOutputControllerTest.PlaySwitchDeviceClose
+      #   AudioStreamHandlerTest.Play
+      #   SoundsManagerTest.Play
+      # Disable AudioStreamHandlerTest.ConsecutivePlayRequests (b/16539293)
+      "media_unittests --gtest_filter=-AudioOutputControllerTest.PlayDivertSwitchDeviceRevertClose:AudioOutputControllerTest.PlaySwitchDeviceClose:AudioStreamHandlerTest.Play:AudioStreamHandlerTest.ConsecutivePlayRequests:PipelineIntegrationTest.BasicPlayback_MediaSource_VP9_WebM:PipelineIntegrationTest.BasicPlayback_VideoOnly_VP9_WebM:PipelineIntegrationTest.BasicPlayback_VP9*:PipelineIntegrationTest.P444_VP9_WebM:PipelineIntegrationTest.BasicPlayback_VP8A*:OpusAudioDecoderTest/AudioDecoderTest.ProduceAudioSamples/0:SoundsManagerTest.Play",
+      "sync_unit_tests --gtest_filter=-SyncHttpBridgeTest.*",
+
+      # DoAppendUTF8Invalid fails because of dcheck_always_on flag in Eng builds
+      "url_unittests --gtest_filter=-URLCanonTest.DoAppendUTF8Invalid",
+    ]
+  } else {

[mbjorge, 2015/10/01 17:11:39]

maybe copy over the "#else x86 or android" comment, to make it more clear, since
the matching if() is kind of far away? Or, even better make it into an 'else if'
with an explicit condition

[slan, 2015/10/01 20:08:03]

Done.

+    filters += [
+      # Disable PipelineIntegrationTest.BasicPlayback_MediaSource_VP9_WebM (not supported)
+      "media_unittests --gtest_filter=-PipelineIntegrationTest.BasicPlayback_MediaSource_VP9_WebM",
+    ]
+  }
+
+  if (!is_android) {
+    tests += [
+      "//chromecast/app:cast_shell_unittests",
+      "//chromecast/browser:cast_shell_broswer_test",
+      "//chromecast/media:cast_media_unittests",
+    ]
+
+    filters += [ "cast_shell_broswer_test --no-sandbox --disable-gpu" ]
+  }
+
+  if (!disable_display) {
+    tests += [ "//gpu:gpu_unittests" ]
+  } else {
+    filters += [
+      # These are not supported by the backend right now. b/21737919
+      "cast_media_unittests --gtest_filter=-AudioVideoPipelineDeviceTest.VorbisPlayback:AudioVideoPipelineDeviceTest.WebmPlayback",
+    ]
+  }
+}
+
+# Creates the build and run lists for all test targets.
+cast_test_group_list("cast_test_lists") {
+  build_list_path = "$root_out_dir/tests/build_test_list.txt"
+  run_list_path = "$root_out_dir/tests/run_test_list.txt"
+  additional_options = [ "--ozone-platform=test" ]
+
+  test_groups = [ ":cast_tests" ]
+
+  if (chromecast_branding != "public") {
+    test_groups += [ "//chromecast/internal:internal_unittests" ]

[mbjorge, 2015/10/01 17:11:40]

the name 'internal_unittests' looks more like a test() target and not a
test_group like 'cast_tests'. maybe cast_internal_tests or internal_cast_tests
for consistency? Or change cast_tests to be cast_unittests?

[slan, 2015/10/01 20:08:03]

Done.

+  }
 }
 
 source_set("cast_shell_common") {