Creating a pexe content handler to translate and run pexes.

mojo/nacl/nonsfi/irt_resource_open.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <fcntl.h>
+
+#include "base/files/file_util.h"
+#include "mojo/nacl/nonsfi/irt_mojo_nonsfi.h"
+#include "native_client/src/untrusted/irt/irt_dev.h"
+
+int nacl_irt_open_resource(const char *pathname, int *newfd) {

[Mark Seaborn, 2015/10/20 21:32:40]

This can go in an anon namespace and follow Chromium naming style.  Same in
irt_pnacl_translator_link/compile.cc too.

[Sean Klein, 2015/10/22 21:50:00]

Done.

+  char path[PATH_MAX];
+  char nonsfi_toolchain[] = "native_client/toolchain/linux_x86"

[Mark Seaborn, 2015/10/20 21:32:40]

This can use 'const'

[Sean Klein, 2015/10/22 21:50:00]

Not done, since changed to string (which has file appended).

+                            "/pnacl_translator/translator/x86-32-nonsfi/lib/";
+  strcpy(path, nonsfi_toolchain);
+  if (strcmp(pathname, "libpnacl_irt_shim.a"))
+    strcat(path, pathname);

[Mark Seaborn, 2015/10/20 21:32:40]

Can you use C++ strings instead?  This overruns the buffer if the caller passes
a long string, which the caller is allowed to do.

[Sean Klein, 2015/10/22 21:50:00]

Done.

+  else
+    strcat(path, "libpnacl_irt_shim_dummy.a");
+  int rv = open(path, O_RDONLY);
+  if (rv < 0)
+    return -rv;

[Mark Seaborn, 2015/10/20 21:32:40]

Should return errno instead.

[Sean Klein, 2015/10/22 21:50:00]

Done.

+  *newfd = rv;
+  return 0;
+}
+
+const struct nacl_irt_resource_open nacl_irt_resource_open = {
+  nacl_irt_open_resource,
+};