Fix pnacl-sz to return with staus 0 in report_fatal_error.

Fix pnacl-sz to return with staus 0 in report_fatal_error.

Fixes pnacl-sz to return with exit status 0 in report_fatal_error, if
command line flag --exit-status is specified. The importance of this
is that it allows afl-fuzz to not report the mutation as a crash.

In addition, afl-fuzz doesn't record crash paths in its search
history.  By returning success, afl-fuzz can continue to apply
additional mutations to the bad input. This allows afl-fuzz to add
errors that require multiple changes to occur on the input.

BUG=None
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=db2fd9c0c3e5cad4c5a99497e226f3ec970cbcad

[Karl, 2015-09-30 16:10:11]

kschimpf@google.com changed reviewers:
+ dschuff@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-09-30 21:32:13]

otherwise LGTM

https://chromiumcodereview.appspot.com/1382653002/diff/1/src/IceCompileServer...
File src/IceCompileServer.cpp (right):

https://chromiumcodereview.appspot.com/1382653002/diff/1/src/IceCompileServer...
src/IceCompileServer.cpp:99: bool gen_crash_diag) {
Should probably be GenCrashDiag or something.

But given that this arg isn't actually used, I'm surprised no "unused parameter"
error is being reported.

[Karl, 2015-09-30 22:02:09]

Committed patchset #2 (id:20001) manually as
db2fd9c0c3e5cad4c5a99497e226f3ec970cbcad (presubmit successful).

[Karl, 2015-09-30 22:02:21]

https://chromiumcodereview.appspot.com/1382653002/diff/1/src/IceCompileServer...
File src/IceCompileServer.cpp (right):

https://chromiumcodereview.appspot.com/1382653002/diff/1/src/IceCompileServer...
src/IceCompileServer.cpp:99: bool gen_crash_diag) {
On 2015/09/30 21:32:13, stichnot wrote:
> Should probably be GenCrashDiag or something.
> 
> But given that this arg isn't actually used, I'm surprised no "unused
parameter"
> error is being reported.

Marking UserData and gen_crash_dag as unused. Surprisingly, when I mark  only
one as unused, I get the "unused parameter" error (doesn't matter which).