Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3240)

Unified Diff: chrome/browser/storage/durable_storage_browsertest.cc

Issue 1382433002: Add durable storage test for incognito. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/storage/durable_storage_browsertest.cc
diff --git a/chrome/browser/storage/durable_storage_browsertest.cc b/chrome/browser/storage/durable_storage_browsertest.cc
index 1c4224ef39a5033d8da0c2519e702ec8ce71c61a..2a517c5dcba51323ff02d5f486e2ba246299ad5c 100644
--- a/chrome/browser/storage/durable_storage_browsertest.cc
+++ b/chrome/browser/storage/durable_storage_browsertest.cc
@@ -31,17 +31,25 @@ class DurableStorageBrowserTest : public InProcessBrowserTest {
void SetUpOnMainThread() override;
protected:
+ content::RenderFrameHost* GetRenderFrameHost(Browser* browser) {
+ return browser->tab_strip_model()->GetActiveWebContents()->GetMainFrame();
+ }
+
content::RenderFrameHost* GetRenderFrameHost() {
- return browser()->tab_strip_model()->GetActiveWebContents()->GetMainFrame();
+ return GetRenderFrameHost(browser());
}
- void Bookmark() {
+ void Bookmark(Browser* browser) {
bookmarks::BookmarkModel* bookmark_model =
- BookmarkModelFactory::GetForProfile(browser()->profile());
+ BookmarkModelFactory::GetForProfile(browser->profile());
bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model);
bookmarks::AddIfNotBookmarked(bookmark_model, url_, base::ASCIIToUTF16(""));
}
+ void Bookmark() {
+ Bookmark(browser());
+ }
+
GURL url_;
private:
@@ -148,3 +156,20 @@ IN_PROC_BROWSER_TEST_F(DurableStorageBrowserTest, FirstTabSeesResult) {
GetRenderFrameHost(), "checkPermission()", &permission_string));
EXPECT_EQ("granted", permission_string);
}
+
+IN_PROC_BROWSER_TEST_F(DurableStorageBrowserTest, Incognito) {
+ Browser* browser = CreateIncognitoBrowser();
+ ui_test_utils::NavigateToURL(browser, url_);
+
+ Bookmark(browser);
+ bool default_box_is_persistent = false;
+ EXPECT_TRUE(content::ExecuteScriptAndExtractBool(GetRenderFrameHost(browser),
+ "requestPermission()",
+ &default_box_is_persistent));
+ EXPECT_TRUE(default_box_is_persistent);
+
+ std::string permission_string;
+ EXPECT_TRUE(content::ExecuteScriptAndExtractString(
+ GetRenderFrameHost(browser), "checkPermission()", &permission_string));
+ EXPECT_EQ("granted", permission_string);
+}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698