Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1382433002: Add durable storage test for incognito. (Closed)

Created:
5 years, 2 months ago by dgrogan
Modified:
5 years, 2 months ago
Reviewers:
jsbell
CC:
chromium-reviews, battre
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add durable storage test for incognito. Incognito is not treated specially. But durability there is a no-op; web storage only uses in memory databases in incognito so there's nothing to protect from disk cleanup. BUG=536613 Committed: https://crrev.com/8f17a6008008c2e2652d7acd62e4fc44a090c9ef Cr-Commit-Position: refs/heads/master@{#351665}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix copyright year #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M chrome/browser/storage/durable_storage_browsertest.cc View 1 3 chunks +29 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgrogan
Josh, could you review this?
5 years, 2 months ago (2015-09-30 00:54:14 UTC) #2
jsbell
lgtm https://chromiumcodereview.appspot.com/1382433002/diff/1/chrome/browser/storage/durable_storage_browsertest.cc File chrome/browser/storage/durable_storage_browsertest.cc (right): https://chromiumcodereview.appspot.com/1382433002/diff/1/chrome/browser/storage/durable_storage_browsertest.cc#newcode1 chrome/browser/storage/durable_storage_browsertest.cc:1: // Copyright (c) 2012 The Chromium Authors. All ...
5 years, 2 months ago (2015-09-30 20:47:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382433002/20001
5 years, 2 months ago (2015-09-30 21:49:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-30 22:43:05 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 22:44:10 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f17a6008008c2e2652d7acd62e4fc44a090c9ef
Cr-Commit-Position: refs/heads/master@{#351665}

Powered by Google App Engine
This is Rietveld 408576698