Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 13824008: Move nodesFromRect from Document to Internals (Closed)

Created:
7 years, 8 months ago by esprehn
Modified:
7 years, 8 months ago
Reviewers:
ojan, abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Move nodesFromRect from Document to Internals This method isn't actually a DOM API and it's used anywhere except in tests. We can move it to Internals to make it clear it shouldn't be used by anything except tests. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -55 lines) Patch
M Source/core/dom/Document.cpp View 2 chunks +0 lines, -53 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 5 chunks +35 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
esprehn
7 years, 8 months ago (2013-04-26 01:39:14 UTC) #1
ojan
lgtm I think we do eventually want to expose an API like this to the ...
7 years, 8 months ago (2013-04-26 01:54:45 UTC) #2
esprehn
On 2013/04/26 01:54:45, ojan wrote: > lgtm > > I think we do eventually want ...
7 years, 8 months ago (2013-04-26 02:09:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/13824008/1
7 years, 8 months ago (2013-04-26 02:09:15 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-26 02:27:22 UTC) #5
Message was sent while issue was closed.
Change committed as 149152

Powered by Google App Engine
This is Rietveld 408576698