Issue 13822002: views/bookmarks: Refactor the way to get the default favicon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13822002: views/bookmarks: Refactor the way to get the default favicon. (Closed)

Created:
7 years, 8 months ago by tfarina

Modified:
7 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views/bookmarks: Refactor the way to get the default favicon. Add a simple function GetDefaultFavicon() to retrieve the default favicon in a way which is similar to the existing GetFolderIcon() function. TEST=launch chrome, add a couple of bookmarks (e.g, about:blank), no regressions observed. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194106

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc	View		3 chunks	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/13822002/1

7 years, 8 months ago (2013-04-13 12:19:18 UTC) #3

Message was sent while issue was closed.

Change committed as 194106

Expand Messages | Collapse Messages