Create a ManagedModeNavigationObserver only for managed users.

Create a ManagedModeNavigationObserver only for managed users.

Non-managed users don't use a ManagedModeNavigationObserver so create one
only for managed users.

R=avi@chromium.org,bauerb@chromium.org,jhawkins@chromium.org

BUG=228843
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193644

[Sergiu, 2013-04-09 13:27:21]

Hey Avi, please take a look. Thanks.

[Avi (use Gerrit), 2013-04-09 14:38:45]

lgtm

[commit-bot: I haz the power, 2013-04-09 14:39:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergiu@chromium.org/13820009/1

[commit-bot: I haz the power, 2013-04-09 16:45:58]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[Sergiu, 2013-04-09 17:33:59]

Hey Bernhard,
Since the profile isn't managed at the time we set things up I had to do the
observer creation separately in the test. I also removed a condition which could
have caused problems when you would start with a blocked page.
Please take a look.

[Bernhard Bauer, 2013-04-09 17:40:39]

On 2013/04/09 17:33:59, Sergiu wrote:
> Hey Bernhard,
> Since the profile isn't managed at the time we set things up I had to do the
> observer creation separately in the test. I also removed a condition which
could
> have caused problems when you would start with a blocked page.
> Please take a look.

Can you add a comment that explains why we need to do that?

Then LGTM.

[commit-bot: I haz the power, 2013-04-10 08:07:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergiu@chromium.org/13820009/16001

[commit-bot: I haz the power, 2013-04-10 10:00:18]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[Sergiu, 2013-04-10 13:08:41]

Hey James, can you take a look at 
chrome/browser/ui/webui/options/managed_user_set_passphrase_test.*?
I'm fixing that test as well, see https://codereview.chromium.org/13820009/#msg5
for more details. Thanks.

[James Hawkins, 2013-04-10 16:16:57]

lgtm

https://codereview.chromium.org/13820009/diff/34001/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/managed_user_set_passphrase_test.h (right):

https://codereview.chromium.org/13820009/diff/34001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/managed_user_set_passphrase_test.h:18: virtual
void SetUpOnMainThread() OVERRIDE;
// WebUIBrowserTest implementation.

[commit-bot: I haz the power, 2013-04-10 16:20:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergiu@chromium.org/13820009/40001

[commit-bot: I haz the power, 2013-04-10 18:12:45]

Retried try job too often on win_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-04-11 12:11:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergiu@chromium.org/13820009/59001

[commit-bot: I haz the power, 2013-04-11 14:52:34]

Change committed as 193644