Issue 13817003: Damage root layer when viewport or top controls changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13817003: Damage root layer when viewport or top controls changes. (Closed)

Created:
7 years, 8 months ago by aelias_OOO_until_Jul13

Modified:
7 years, 8 months ago

Reviewers:
danakj, enne (OOO)

CC:
chromium-reviews, cc-bugs_chromium.org, David Trainor- moved to gerrit, Yusuf

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Damage root layer when viewport or top controls changes. http://crrev.com/192706 broke top controls hiding because this situation doesn't cause any damage, meaning no renderer frames are sent. Fix it by causing full root layer damage whenever one of the inputs to VisibleViewportSize changes. NOTRY=true BUG=229138 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193011

Patch Set 1 #

Patch Set 2 : Fix compile #

Patch Set 3 : Fix compile 2 #

Patch Set 4 : Fix LayerTreeHostDelegatedTestLayerUsesFrameDamage #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -29 lines)			Patch
M	cc/input/top_controls_manager.cc	View		3 chunks	+4 lines, -5 lines	0 comments	Download
M	cc/input/top_controls_manager_client.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	cc/input/top_controls_manager_unittest.cc	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	cc/trees/layer_tree_host_impl.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	cc/trees/layer_tree_host_impl.cc	View		4 chunks	+7 lines, -6 lines	0 comments	Download
M	cc/trees/layer_tree_host_perftest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	cc/trees/layer_tree_host_unittest_delegated.cc	View	1 2 3	1 chunk	+2 lines, -3 lines	0 comments	Download
M	cc/trees/layer_tree_host_unittest_scroll.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	cc/trees/layer_tree_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/13817003/14001

7 years, 8 months ago (2013-04-09 04:10:20 UTC) #4

Message was sent while issue was closed.

Change committed as 193011

Expand Messages | Collapse Messages