Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4480)

Unified Diff: chrome/browser/resources/settings/signin_page/signin_page.js

Issue 1381553003: Settings Rewrite: Add Sign-in (Chrome) section (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/signin_page/signin_page.js
diff --git a/chrome/browser/resources/settings/basic_page/basic_page.js b/chrome/browser/resources/settings/signin_page/signin_page.js
similarity index 59%
copy from chrome/browser/resources/settings/basic_page/basic_page.js
copy to chrome/browser/resources/settings/signin_page/signin_page.js
index 024794acba024be1ef35fdc9a3518dce77520de5..bdac14597d5c944e8b29a750a8d06d627f0ee8dd 100644
--- a/chrome/browser/resources/settings/basic_page/basic_page.js
+++ b/chrome/browser/resources/settings/signin_page/signin_page.js
@@ -4,31 +4,23 @@
/**
* @fileoverview
- * 'cr-settings-basic-page' is the settings page containing the basic settings.
+ * 'cr-settings-signin-page' is the settings page containing sign-in settings.
*
* Example:
*
* <iron-animated-pages>
- * <cr-settings-basic-page prefs="{{prefs}}"></cr-settings-basic-page>
+ * <cr-settings-signin-page prefs="{{prefs}}"></cr-settings-signin-page>
* ... other pages ...
* </iron-animated-pages>
*
* @group Chrome Settings Elements
- * @element cr-settings-basic-page
+ * @element cr-settings-signin-page
*/
Polymer({
- is: 'cr-settings-basic-page',
+ is: 'cr-settings-signin-page',
Dan Beam 2015/09/30 22:43:16 add new pages without the cr-
tommycli 2015/10/01 16:44:59 Done.
properties: {
/**
- * Preferences state.
- */
- prefs: {
- type: Object,
- notify: true,
- },
-
- /**
* The current active route.
*/
currentRoute: {
@@ -36,4 +28,9 @@ Polymer({
notify: true,
},
},
+
+ /** @private */
+ onSyncTap_: function() {
+ this.$.pages.setSubpageChain(['sync']);
+ },
});

Powered by Google App Engine
This is Rietveld 408576698