chrome/browser/resources/settings/signin_page/signin_page.html - Issue 1381553003: Settings Rewrite: Add Sign-in (Chrome) section

Side by Side Diff: chrome/browser/resources/settings/signin_page/signin_page.html

Issue 1381553003: Settings Rewrite: Add Sign-in (Chrome) section (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/signin_page/signin_page.css ('K') | « chrome/browser/resources/settings/signin_page/signin_page.css ('k') | chrome/browser/resources/settings/signin_page/signin_page.js » ('j') | chrome/browser/resources/settings/signin_page/signin_page.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

	4 <link rel="import" href="chrome://md-settings/sync_page/sync_page.html">

	5 <link rel="import" href="chrome://md-settings/settings_page/settings_animated_pa ges.html">

	6 <link rel="import" href="chrome://md-settings/settings_page/settings_subheader.h tml">

	7

	8 <dom-module id="cr-settings-signin-page">

	9 <link rel="import" type="css"

	10 href="chrome://md-settings/settings_page/settings_page.css">

	11 <link rel="import" type="css" href="signin_page.css">

	12 <template>

	13 <cr-settings-animated-pages id="pages" current-route="{{currentRoute}}"

	14 section="signin">

	15 <neon-animatable id="">
	Dan Beam 2015/09/30 22:43:16 why can't we just put <neon-animatable id>? why can't we just put <neon-animatable id>? tommycli 2015/10/01 16:44:59 It technically works, however, I think it's less c Show quoted text On 2015/09/30 22:43:16, Dan Beam wrote: > why can't we just put <neon-animatable id>? It technically works, however, I think it's less confusing to write id="", as then we are explicitly giving it an empty string id, whereas the other way makes it seem like it 'has a' id. Alternatively I can change it back to id="main" for the default page in a separate patch if the above seems confusing. michaelpg 2015/10/03 05:23:31 ^ that Show quoted text On 2015/10/01 16:44:59, tommycli wrote: > On 2015/09/30 22:43:16, Dan Beam wrote: > > why can't we just put <neon-animatable id>? > > It technically works, however, I think it's less confusing to write id="", as > then we are explicitly giving it an empty string id, whereas the other way makes > it seem like it 'has a' id. > > Alternatively I can change it back to id="main" for the default page in a > separate patch if the above seems confusing. ^ that tommycli 2015/10/05 17:15:45 Sounds good I'll change it back to id="main" for a Show quoted text On 2015/10/03 05:23:31, michaelpg (OOO til 19th) wrote: > On 2015/10/01 16:44:59, tommycli wrote: > > On 2015/09/30 22:43:16, Dan Beam wrote: > > > why can't we just put <neon-animatable id>? > > > > It technically works, however, I think it's less confusing to write id="", as > > then we are explicitly giving it an empty string id, whereas the other way > makes > > it seem like it 'has a' id. > > > > Alternatively I can change it back to id="main" for the default page in a > > separate patch if the above seems confusing. > > ^ that Sounds good I'll change it back to id="main" for all of them
	16 <paper-button i18n-content="syncPageTitle" on-tap="onSyncTap_" raised>

	17 </paper-button>

	18 </neon-animatable>

	19 <neon-animatable id="sync">

	20 <settings-subheader i18n-values="page-title:syncPageTitle">

	21 </settings-subheader>

	22 <cr-settings-sync-page current-route="[[currentRoute]]">

	23 </cr-settings-sync-page>

	24 </neon-animatable>

	25 </cr-settings-animated-pages>

	26 </template>

	27 <script src="signin_page.js"></script>

	28 </dom-module>

OLD	NEW