Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 1381553003: Settings Rewrite: Add Sign-in (Chrome) section (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-router' is a simple router for settings. Its responsibilites: 7 * 'settings-router' is a simple router for settings. Its responsibilites:
8 * - Update the URL when the routing state changes. 8 * - Update the URL when the routing state changes.
9 * - Initialize the routing state with the initial URL. 9 * - Initialize the routing state with the initial URL.
10 * - Process and validate all routing state changes. 10 * - Process and validate all routing state changes.
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 subpageTitles: ['searchEnginesPageTitle'], 105 subpageTitles: ['searchEnginesPageTitle'],
106 }, 106 },
107 { 107 {
108 url: '/searchEngines/advanced', 108 url: '/searchEngines/advanced',
109 page: 'basic', 109 page: 'basic',
110 section: 'search', 110 section: 'search',
111 subpage: ['search-engines', 'search-engines-advanced'], 111 subpage: ['search-engines', 'search-engines-advanced'],
112 subpageTitles: ['searchEnginesPageTitle', 'advancedPageTitle'], 112 subpageTitles: ['searchEnginesPageTitle', 'advancedPageTitle'],
113 }, 113 },
114 { 114 {
115 url: '/syncSetup',
Dan Beam 2015/09/30 22:43:16 is there an order to these? can we alphabetize by
tommycli 2015/10/01 16:44:59 No current order. This delta doesn't break the ord
116 page: 'basic',
117 section: 'signin',
118 subpage: ['sync'],
119 subpageTitles: ['syncPageTitle'],
120 },
121 {
115 url: '/certificates', 122 url: '/certificates',
116 page: 'advanced', 123 page: 'advanced',
117 section: 'privacy', 124 section: 'privacy',
118 subpage: ['manage-certificates'], 125 subpage: ['manage-certificates'],
119 subpageTitles: ['manageCertificates'], 126 subpageTitles: ['manageCertificates'],
120 }, 127 },
121 { 128 {
122 url: '/content', 129 url: '/content',
123 page: 'advanced', 130 page: 'advanced',
124 section: 'privacy', 131 section: 'privacy',
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 history.replaceState(historicState, null); 218 history.replaceState(historicState, null);
212 } 219 }
213 220
214 return; 221 return;
215 } 222 }
216 } 223 }
217 224
218 assertNotReached('Route not found: ' + JSON.stringify(newRoute)); 225 assertNotReached('Route not found: ' + JSON.stringify(newRoute));
219 }, 226 },
220 }); 227 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698