tools/metrics/histograms/histograms.xml - Issue 1381463003: Add warning message for empty robustness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1381463003: Add warning message for empty robustness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments addressed Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index b61a47929def396f138a0f1f311cb5e9a13fdfaa..e81cd8f675a049ad549640a515ff960456a7aaae 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -17524,6 +17524,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<summary>System code count using the Widevine key system.</summary>

</histogram>

+<histogram name="Media.EME.Widevine.VideoCapability.HasEmptyRobustness"

+ enum="Boolean">

Ilya Sherman 2015/10/02 04:14:12 nit: Please define a custom boolean enum, BooleanE

xhwang 2015/10/02 16:45:07 Done.

+ <owner>xhwang@chromium.org</owner>

+ <summary>

+ Whether the robustness level of any video capability in the supported

+ configuration passed into requestMediaKeySystemAccess() is empty. This is

+ specific to the Widevine key system.

ddorwin 2015/10/02 01:19:04 nit: This last sentence is redundant with the name

xhwang 2015/10/02 04:02:33 Well, we do mention Widevine in other Media.EME.Wi

+ </summary>

+</histogram>

<owner>dalecurtis@chromium.org</owner>

« no previous file with comments | « third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp ('k') | no next file » | no next file with comments »