Linux: make current InitializeSandbox() private.

Linux: make current InitializeSandbox() private.

The current InitializeSandbox() is only usable from inside
of content/, make it part of the content-specific LinuxSandbox class.

BUG=229673
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194072

[jln (very slow on Chromium), 2013-04-10 02:24:30]

Markus, do you mind taking a quick look ?

This is a refactor, and I intend to ask jam@ for an owner review since it's the
first step in a larger refactor.

So please have a quick look for typos and obvious mistake, but I expect code
organization to be discussed later.

PS: Also FYI, I think we've reached the point where it could be time to fully
retire seccomp-legacy. It's making initialization a lot more complicated than it
could be and we don't even support Linux distributions without seccomp-bpf at
this point anymore. We can discuss this in person or in a separate thread. It's
still fully supported in this CL.

[Markus (顧孟勤), 2013-04-10 23:39:50]

lgtm

A quick look over the CL doesn't reveal any obvious problems.

As you asked, I didn't actually look in depth or verified that this is the right
thing to do. But in general, it looks like a good clean up.

https://chromiumcodereview.appspot.com/13814027/diff/8004/content/common/sand...
File content/common/sandbox_linux.h (right):

https://chromiumcodereview.appspot.com/13814027/diff/8004/content/common/sand...
content/common/sandbox_linux.h:70: // works differently and is set-up in the
Zygote). This will instanciate the
s/instanciate/instantiate/

[jln (very slow on Chromium), 2013-04-11 00:06:03]

John, could you take a look as content/ owner ? Also please take a quick look at
the linked bug. Or should I rather ask Antoine?

[jln (very slow on Chromium), 2013-04-12 22:24:41]

John, I have reverted the explicit sandbox configuration parameter to
InitializeSandbox().

This now just moves a private-in-pratice interface out of public/.

PTAL!

[jam, 2013-04-12 23:25:34]

lgtm

https://chromiumcodereview.appspot.com/13814027/diff/24001/content/public/com...
File content/public/common/sandbox_init.h (right):

https://chromiumcodereview.appspot.com/13814027/diff/24001/content/public/com...
content/public/common/sandbox_init.h:83: // Not implemented at the moment.
nit: why not delete this method now and the cc file?

[jln (very slow on Chromium), 2013-04-12 23:54:02]

https://chromiumcodereview.appspot.com/13814027/diff/24001/content/public/com...
File content/public/common/sandbox_init.h (right):

https://chromiumcodereview.appspot.com/13814027/diff/24001/content/public/com...
content/public/common/sandbox_init.h:83: // Not implemented at the moment.
On 2013/04/12 23:25:34, jam wrote:
> nit: why not delete this method now and the cc file?

I thought it would be nicer to point to the bug planning to implement it (which
I somehow forgot to do in the interface).

I removed the method and the cc file.

[commit-bot: I haz the power, 2013-04-12 23:54:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/13814027/30001

[commit-bot: I haz the power, 2013-04-13 01:56:23]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-13 02:00:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/13814027/30001

[commit-bot: I haz the power, 2013-04-13 02:00:51]

Change committed as 194072