Chromium Code Reviews
Help | Chromium Project | Sign in
(525)

Issue 13814024: Add a runtime flag in WebRuntimeFeatures to enable 'image/webp' accept header (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by urvang (Google)
Modified:
1 year ago
Reviewers:
darin
CC:
blink-reviews_chromium.org, jamesr (out of office), abarth_chromum.org, abarth, gavinp+loader_chromium.org, haraken, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add a runtime flag in WebRuntimeFeatures to enable 'image/webp' accept header
BUG=169182
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148318

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Lint Patch
M Source/WebCore/loader/cache/CachedImage.h View 1 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M Source/WebCore/loader/cache/CachedImage.cpp View 1 4 chunks +14 lines, -0 lines 0 comments 3 errors Download
M Source/WebKit/chromium/public/WebRuntimeFeatures.h View 1 1 chunk +4 lines, -0 lines 0 comments 1 errors Download
M Source/WebKit/chromium/src/WebRuntimeFeatures.cpp View 1 1 chunk +18 lines, -0 lines 0 comments 2 errors Download
M Source/bindings/v8/RuntimeEnabledFeatures.h View 1 2 chunks +9 lines, -0 lines 0 comments 3 errors Download
M Source/bindings/v8/RuntimeEnabledFeatures.cpp View 1 1 chunk +4 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 11
urvang (Google)
1 year ago #1
darin
https://codereview.chromium.org/13814024/diff/1/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h File Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (right): https://codereview.chromium.org/13814024/diff/1/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h#newcode287 Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h:287: #if USE(WEBP) WTF_USE_WEBP is no longer required in Blink. ...
1 year ago #2
urvang (Google)
Thanks Darin! Reply inline... https://codereview.chromium.org/13814024/diff/1/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h File Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (right): https://codereview.chromium.org/13814024/diff/1/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h#newcode287 Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h:287: #if USE(WEBP) On 2013/04/10 23:13:16, ...
1 year ago #3
darin
OK, LGTM I would like to see WTF_USE_WEBP removed. I don't think we need to ...
1 year ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/urvang@google.com/13814024/1
1 year ago #5
I haz the power (commit-bot)
Failed to apply patch for Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; A Source/WebCore/bindings ...
1 year ago #6
urvang (Google)
Looks like some files have moved recently. Here is a rebased change.
1 year ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/urvang@google.com/13814024/9001
1 year ago #8
I haz the power (commit-bot)
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=1970
1 year ago #9
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/urvang@google.com/13814024/9001
1 year ago #10
I haz the power (commit-bot)
1 year ago #11
Message was sent while issue was closed.
Change committed as 148318
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6