Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1530)

Issue 13814009: Fix failing ExtensionIconManagerTest.LoadComponentExtensionResource (Closed)

Created:
7 years, 8 months ago by hashimoto
Modified:
7 years, 8 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fix failing ExtensionIconManagerTest.LoadComponentExtensionResource Profile should be set up before creating Extension. BUG=229246 TEST=unit_tests --gtest_filter="ExtensionIconManagerTest.LoadComponentExtensionResource" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193325

Patch Set 1 #

Total comments: 4

Patch Set 2 : inherit ExtensionTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/extensions/extension_icon_manager_unittest.cc View 1 5 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
Please review.
7 years, 8 months ago (2013-04-09 11:57:35 UTC) #1
Yoyo Zhou
LGTM, but also a few suggested changes https://codereview.chromium.org/13814009/diff/1/chrome/browser/extensions/extension_icon_manager_unittest.cc File chrome/browser/extensions/extension_icon_manager_unittest.cc (right): https://codereview.chromium.org/13814009/diff/1/chrome/browser/extensions/extension_icon_manager_unittest.cc#newcode24 chrome/browser/extensions/extension_icon_manager_unittest.cc:24: class ExtensionIconManagerTest ...
7 years, 8 months ago (2013-04-09 17:19:28 UTC) #2
hashimoto
Thank you for reviewing. Going to submit. https://codereview.chromium.org/13814009/diff/1/chrome/browser/extensions/extension_icon_manager_unittest.cc File chrome/browser/extensions/extension_icon_manager_unittest.cc (right): https://codereview.chromium.org/13814009/diff/1/chrome/browser/extensions/extension_icon_manager_unittest.cc#newcode24 chrome/browser/extensions/extension_icon_manager_unittest.cc:24: class ExtensionIconManagerTest ...
7 years, 8 months ago (2013-04-10 02:40:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/13814009/6001
7 years, 8 months ago (2013-04-10 02:42:54 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 04:53:13 UTC) #5
Message was sent while issue was closed.
Change committed as 193325

Powered by Google App Engine
This is Rietveld 408576698