Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: net/disk_cache/disk_cache_test_base.cc

Issue 13813015: Separate Simple Backend creation from initialization. (Closed) Base URL: http://git.chromium.org/chromium/src.git@trace-2
Patch Set: updated the simple backend initialization according to the new interface in tests Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/disk_cache_test_base.cc
diff --git a/net/disk_cache/disk_cache_test_base.cc b/net/disk_cache/disk_cache_test_base.cc
index df913fbf5484031bbf9563545cc1d2177cf9c3ef..10fbd50c4816bf7e340b6efa8e07c23d83e94014 100644
--- a/net/disk_cache/disk_cache_test_base.cc
+++ b/net/disk_cache/disk_cache_test_base.cc
@@ -268,11 +268,10 @@ void DiskCacheTestWithCache::CreateBackend(uint32 flags, base::Thread* thread) {
if (simple_cache_mode_) {
net::TestCompletionCallback cb;
- disk_cache::Backend* simple_backend;
- // TODO(pasko): split Simple Backend construction from initialization.
- int rv = disk_cache::SimpleBackendImpl::CreateBackend(cache_path_, size_,
- type_, disk_cache::kNone, make_scoped_refptr(runner), NULL,
- &simple_backend, cb.callback());
+ disk_cache::SimpleBackendImpl* simple_backend =
+ new disk_cache::SimpleBackendImpl(cache_path_, size_, type_,
+ make_scoped_refptr(runner), NULL);
+ int rv = simple_backend->Init(cb.callback());
ASSERT_EQ(net::OK, cb.GetResult(rv));
cache_ = simple_backend;
return;

Powered by Google App Engine
This is Rietveld 408576698