Fix ibus-m17n crash due to wrong parameter from Chrome.

Fix ibus-m17n crash due to wrong parameter from Chrome.

The argument of SetSurroundingText is relative position from passing surrounding
text. Here selection_range or text_range is absolute position from document
root, thus we need conversion.

BUG=222392
TEST=type "a" 140 times with Thai input and made sure not crashing.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193353

[Seigo Nonaka, 2013-04-10 04:04:27]

Satoru-san is OOO today, Inaba-san could you take a look?

Thank you.

[kinaba, 2013-04-10 04:12:35]

https://codereview.chromium.org/13812013/diff/3/ui/base/ime/input_method_ibus.cc
File ui/base/ime/input_method_ibus.cc (right):

https://codereview.chromium.org/13812013/diff/3/ui/base/ime/input_method_ibus...
ui/base/ime/input_method_ibus.cc:273: selection_range.end() - text_range.end());
 // selection anchor position.
Shouldn't it be text_range.start(), not the .end()?

[Seigo Nonaka, 2013-04-10 04:22:26]

Thank you!
I changed unit tests expectation to immediate value.

PTAL?

https://codereview.chromium.org/13812013/diff/3/ui/base/ime/input_method_ibus.cc
File ui/base/ime/input_method_ibus.cc (right):

https://codereview.chromium.org/13812013/diff/3/ui/base/ime/input_method_ibus...
ui/base/ime/input_method_ibus.cc:273: selection_range.end() - text_range.end());
 // selection anchor position.
Yes, good catch! thank you very much!
On 2013/04/10 04:12:35, kinaba wrote:
> Shouldn't it be text_range.start(), not the .end()?

[kinaba, 2013-04-10 04:30:04]

lgtm (with some suggestion for comments)

https://codereview.chromium.org/13812013/diff/6001/ui/base/ime/input_method_i...
File ui/base/ime/input_method_ibus.cc (right):

https://codereview.chromium.org/13812013/diff/6001/ui/base/ime/input_method_i...
ui/base/ime/input_method_ibus.cc:272: // cursor position.
please add a comment that the position has to be given in the relative index
from surrounding_text

https://codereview.chromium.org/13812013/diff/6001/ui/base/ime/input_method_i...
File ui/base/ime/input_method_ibus_unittest.cc (right):

https://codereview.chromium.org/13812013/diff/6001/ui/base/ime/input_method_i...
ui/base/ime/input_method_ibus_unittest.cc:1209: SetSurroundingTextVerifier
verifier("fghij", 2, 4);
please add comment about how the (2, 4) came up.

[Seigo Nonaka, 2013-04-10 05:15:54]

Thank you for your review!

https://codereview.chromium.org/13812013/diff/6001/ui/base/ime/input_method_i...
File ui/base/ime/input_method_ibus.cc (right):

https://codereview.chromium.org/13812013/diff/6001/ui/base/ime/input_method_i...
ui/base/ime/input_method_ibus.cc:272: // cursor position.
On 2013/04/10 04:30:04, kinaba wrote:
> please add a comment that the position has to be given in the relative index
> from surrounding_text

Done.

https://codereview.chromium.org/13812013/diff/6001/ui/base/ime/input_method_i...
File ui/base/ime/input_method_ibus_unittest.cc (right):

https://codereview.chromium.org/13812013/diff/6001/ui/base/ime/input_method_i...
ui/base/ime/input_method_ibus_unittest.cc:1209: SetSurroundingTextVerifier
verifier("fghij", 2, 4);
On 2013/04/10 04:30:04, kinaba wrote:
> please add comment about how the (2, 4) came up.

Done.

[commit-bot: I haz the power, 2013-04-10 05:25:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/13812013/13001

[commit-bot: I haz the power, 2013-04-10 09:11:43]

Change committed as 193353