Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 13812009: Make ContentViewRenderView's SurfaceView injectable (Closed)

Created:
7 years, 8 months ago by wonsik
Modified:
7 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, googletv-nikita_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make ContentViewRenderView's SurfaceView injectable For apps using ContentViewRenderView, make it possible to inject SurfaceView object that ContentViewRenderView will use. Provide default operation which just creates a new SurfaceView object. BUG=229369 R=yfriedman@chromium.org TBR=yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193347

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added javadoc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java View 1 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
wonsik
Please take a look. Thanks!
7 years, 8 months ago (2013-04-09 12:33:26 UTC) #1
wonsik
+ycheo
7 years, 8 months ago (2013-04-09 12:34:03 UTC) #2
Yaron
+dtrainor
7 years, 8 months ago (2013-04-09 16:20:41 UTC) #3
David Trainor- moved to gerrit
lgtm https://codereview.chromium.org/13812009/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java File content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java (right): https://codereview.chromium.org/13812009/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java#newcode93 content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java:93: protected SurfaceView createSurfaceView(Context context) { javadoc :)
7 years, 8 months ago (2013-04-09 17:21:21 UTC) #4
wonsik
Thanks for the quick review! https://codereview.chromium.org/13812009/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java File content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java (right): https://codereview.chromium.org/13812009/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java#newcode93 content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java:93: protected SurfaceView createSurfaceView(Context context) ...
7 years, 8 months ago (2013-04-10 01:39:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wonsik@chromium.org/13812009/7001
7 years, 8 months ago (2013-04-10 01:39:48 UTC) #6
commit-bot: I haz the power
Presubmit check for 13812009-7001 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-10 01:39:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wonsik@chromium.org/13812009/7001
7 years, 8 months ago (2013-04-10 04:57:46 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 08:51:14 UTC) #9
Message was sent while issue was closed.
Change committed as 193347

Powered by Google App Engine
This is Rietveld 408576698