Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 13811056: Added variable initialization (valgrind complains). (Closed)

Created:
7 years, 8 months ago by motek.
Modified:
7 years, 8 months ago
Reviewers:
Nico, grt (UTC plus 2)
CC:
chromium-reviews
Visibility:
Public.

Description

Added variable initialization (valgrind complains). This fix should make valgrind bots green (or at least remove one of sources of unhappiness). BUG=233153 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194937

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed the nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/thumbnails/content_analysis_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
grt (UTC plus 2)
lgtm https://codereview.chromium.org/13811056/diff/1/chrome/browser/thumbnails/content_analysis_unittest.cc File chrome/browser/thumbnails/content_analysis_unittest.cc (right): https://codereview.chromium.org/13811056/diff/1/chrome/browser/thumbnails/content_analysis_unittest.cc#newcode473 chrome/browser/thumbnails/content_analysis_unittest.cc:473: int histogram[256] = { 0 }; nit: remove ...
7 years, 8 months ago (2013-04-18 13:38:47 UTC) #1
motek.
Fixed the nit, about to queue up for CQ. TBRign as per grt@'s advice to ...
7 years, 8 months ago (2013-04-18 14:03:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/motek@chromium.org/13811056/3001
7 years, 8 months ago (2013-04-18 14:04:26 UTC) #3
commit-bot: I haz the power
Change committed as 194937
7 years, 8 months ago (2013-04-18 16:17:36 UTC) #4
Nico
7 years, 8 months ago (2013-04-18 17:34:02 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698