[Android] Split Ant -package and -package-resources

[Android] Split Ant -package and -package-resources

Splits apk-package.xml into apk-package.xml and
apk-package-resources.xml and adds a new gyp action for
package-resources.

This continues the simplification of gyp actions (i.e. each individual
action should be simple).

Also, allows more accurate specification of inputs for
-package-resources vs -package (and allows -package-resources to be
done in parallel with javac/dex/etc.).

BUG=158821
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193491

[shashi, 2013-04-09 18:34:47]

lgtm

[cjhopman, 2013-04-09 20:50:18]

yfriedman@ for OWNERS

[Yaron, 2013-04-10 00:08:02]

lgtm

java_apk.gypi is now over 600 lines :S

[commit-bot: I haz the power, 2013-04-10 00:11:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13811027/1

[commit-bot: I haz the power, 2013-04-10 00:11:13]

Failed to apply patch for build/java_apk.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/java_apk.gypi
  Hunk #4 succeeded at 587 with fuzz 1 (offset 41 lines).
  Hunk #5 FAILED at 556.
  1 out of 5 hunks FAILED -- saving rejects to file build/java_apk.gypi.rej

Patch:       build/java_apk.gypi
Index: build/java_apk.gypi
diff --git a/build/java_apk.gypi b/build/java_apk.gypi
index
3b505f99a06ebfc862cb5fd4a7d29f1cf30fc732..175df40e338abcad1c32e19edc6277c34bf4d009
100644
--- a/build/java_apk.gypi
+++ b/build/java_apk.gypi
@@ -100,6 +100,7 @@
     'android_manifest_path%': '<(java_in_dir)/AndroidManifest.xml',
     'push_stamp': '<(intermediate_dir)/push.stamp',
     'link_stamp': '<(intermediate_dir)/link.stamp',
+    'package_resources_stamp': '<(intermediate_dir)/package_resources.stamp',
     'codegen_input_paths': [],
     'keystore_path': '<(DEPTH)/build/android/ant/chromium-debug.keystore',
     'unsigned_apk_path': '<(intermediate_dir)/<(apk_name)-unsigned.apk',
@@ -345,9 +346,10 @@
         '<(DEPTH)/build/android/gyp/util/build_utils.py',
         '<(DEPTH)/build/android/gyp/ant.py',
         '<(android_manifest_path)',
-        '>@(library_manifest_paths)'
-        '>@(codegen_input_paths)',
         '>@(additional_input_paths)',
+        '>@(codegen_input_paths)',
+        '>@(library_manifest_paths)'
+        '>@(resource_input_paths)',
       ],
       'outputs': [
         '<(codegen_stamp)',
@@ -523,16 +525,17 @@
       ]
     },
     {
-      'action_name': 'ant_package_<(_target_name)',
-      'message': 'Packaging <(_target_name).',
+      'action_name': 'ant package resources',
+      'message': 'Packaging resources for <(_target_name) APK.',
       'inputs': [
-        '<(DEPTH)/build/android/ant/apk-package.xml',
+        '<(DEPTH)/build/android/ant/apk-package-resources.xml',
         '<(DEPTH)/build/android/gyp/util/build_utils.py',
         '<(DEPTH)/build/android/gyp/ant.py',
-        '<(dex_path)',
+        '<(android_manifest_path)',
         '<(codegen_stamp)',
-        '<(obfuscate_stamp)',
-        '>@(package_input_paths)',
+
+        '>@(library_manifest_paths)',
+        '>@(additional_input_paths)',
       ],
       'conditions': [
         ['is_test_apk == 1', {
@@ -543,7 +546,7 @@
         }],
       ],
       'outputs': [
-        '<(final_apk_path)',
+        '<(package_resources_stamp)',
       ],
       'action': [
         'python', '<(DEPTH)/build/android/gyp/ant.py',
@@ -553,15 +556,50 @@
         '-DADDITIONAL_R_TEXT_FILES=>(additional_R_text_files)',
         '-DANDROID_SDK_JAR=<(android_sdk_jar)',
         '-DANDROID_SDK_ROOT=<(android_sdk_root)',
-        '-DANDROID_SDK_VERSION=<(android_sdk_version)',
         '-DAPK_NAME=<(apk_name)',
         '-DAPP_MANIFEST_VERSION_CODE=<(app_manifest_version_code)',
         '-DAPP_MANIFEST_VERSION_NAME=<(app_manifest_version_name)',
         '-DASSET_DIR=<(asset_location)',
         '-DCONFIGURATION_NAME=<(CONFIGURATION_NAME)',
-        '-DNATIVE_LIBS_DIR=<(apk_package_native_libs_dir)',
         '-DOUT_DIR=<(intermediate_dir)',
         '-DRESOURCE_DIR=<(resource_dir)',
+
+        '-DSTAMP=<(package_resources_stamp)',
+
+        '-Dbasedir=.',
+        '-buildfile',
+        '<(DEPTH)/build/android/ant/apk-package-resources.xml',
+
+        # Add list of inputs to the command line, so if inputs change
+        # (e.g. if a Java file is removed), the command will be re-run.
+        # TODO(newt): remove this once crbug.com/177552 is fixed in ninja.
+        '-DTHIS_IS_IGNORED=>!(echo \'>(_inputs)\' | md5sum)',
+      ]
+    },
+    {
+      'action_name': 'ant_package_<(_target_name)',
+      'message': 'Packaging <(_target_name).',
+      'inputs': [
+        '<(DEPTH)/build/android/ant/apk-package.xml',
+        '<(DEPTH)/build/android/gyp/util/build_utils.py',
+        '<(DEPTH)/build/android/gyp/ant.py',
+        '<(dex_path)',
+        '<(codegen_stamp)',
+        '<(obfuscate_stamp)',
+        '<(package_resources_stamp)',
+        '>@(package_input_paths)',
+      ],
+      'outputs': [
+        '<(unsigned_apk_path)',
+      ],
+      'action': [
+        'python', '<(DEPTH)/build/android/gyp/ant.py',
+        '-quiet',
+        '-DANDROID_SDK_ROOT=<(android_sdk_root)',
+        '-DAPK_NAME=<(apk_name)',
+        '-DCONFIGURATION_NAME=<(CONFIGURATION_NAME)',
+        '-DNATIVE_LIBS_DIR=<(apk_package_native_libs_dir)',
+        '-DOUT_DIR=<(intermediate_dir)',
         '-DSOURCE_DIR=<(source_dir)',
         '-DUNSIGNED_APK_PATH=<(unsigned_apk_path)',

[commit-bot: I haz the power, 2013-04-10 20:08:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13811027/8001

[commit-bot: I haz the power, 2013-04-10 20:19:00]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-10 20:45:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13811027/21001

[commit-bot: I haz the power, 2013-04-10 23:10:19]

Change committed as 193491