Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: webkit/fileapi/file_system_mount_point_provider.h

Issue 13811013: Refactor FileSystemMountPointProvider::CreateFileStream{Reader,Writer} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: conflict fix Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/fileapi/file_system_context.cc ('k') | webkit/fileapi/file_system_url_request_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/fileapi/file_system_mount_point_provider.h
diff --git a/webkit/fileapi/file_system_mount_point_provider.h b/webkit/fileapi/file_system_mount_point_provider.h
index 066c2ab3ef216b5e62530d66bb0496dceb09fe2f..9ca3997f73ed8e6091910a1b13028fd54979d2f4 100644
--- a/webkit/fileapi/file_system_mount_point_provider.h
+++ b/webkit/fileapi/file_system_mount_point_provider.h
@@ -104,10 +104,9 @@ class WEBKIT_STORAGE_EXPORT FileSystemMountPointProvider {
// file's actual modification time to see if the file has been modified, and
// if it does any succeeding read operations should fail with
// ERR_UPLOAD_FILE_CHANGED error.
- // The returned object must be owned and managed by the caller.
// This method itself does *not* check if the given path exists and is a
// regular file.
- virtual webkit_blob::FileStreamReader* CreateFileStreamReader(
+ virtual scoped_ptr<webkit_blob::FileStreamReader> CreateFileStreamReader(
const FileSystemURL& url,
int64 offset,
const base::Time& expected_modification_time,
@@ -115,10 +114,9 @@ class WEBKIT_STORAGE_EXPORT FileSystemMountPointProvider {
// Creates a new file stream writer for a given filesystem URL |url| with an
// offset |offset|.
- // The returned object must be owned and managed by the caller.
// This method itself does *not* check if the given path exists and is a
// regular file.
- virtual FileStreamWriter* CreateFileStreamWriter(
+ virtual scoped_ptr<FileStreamWriter> CreateFileStreamWriter(
const FileSystemURL& url,
int64 offset,
FileSystemContext* context) const = 0;
« no previous file with comments | « webkit/fileapi/file_system_context.cc ('k') | webkit/fileapi/file_system_url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698