Fix typo: s/Aquire/Acquire/

Fix typo: s/Aquire/Acquire/	

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192953

[mdempsky_google, 2013-04-08 21:02:58]

Hi Jeff, I'd like you to do a code review.

Although Skia conventionally typos "acquire" as "aquire" in their APIs, there's
no Aquire_CompareAndSwap() function in Chromium base::subtle.  It should be
Acquire_CompareAndSwap().

This code doesn't appear to be compiled for Linux, Android, Mac, iOS, or
Windows, but it does get compiled on OSes like OpenBSD and FreeBSD (both of
which currently patch it themselves for packaging).

Thanks!

[mdempsky_google, 2013-04-08 21:21:03]

Hi Mike Reed, I'd like you to do a code review.

"gcl upload" recommended twiz as a reviewer for this patch, but I just noticed
he's no longer at Google and doesn't appear active on chromium-reviews@ anymore
either, so lucky you. :)

[reed1, 2013-04-08 21:24:34]

I agree with the new spelling, but I don't understand how we had this be wrong
before. Does chrome never build/test this file? If so, and if that is by design,
perhaps we should remove the file rather than "fix" it (since we won't be able
to test the fix).

[mdempsky_google, 2013-04-08 21:28:36]

On 2013/04/08 21:24:34, reed1 wrote:
> I agree with the new spelling, but I don't understand how we had this be wrong
> before. Does chrome never build/test this file? If so, and if that is by
design,
> perhaps we should remove the file rather than "fix" it (since we won't be able
> to test the fix).

Sorry, I should have included my original explanation in the second review
request mail.

This file gets explicitly excluded from the Linux, Android, Mac, iOS, and
Windows builds, but it does get included in other builds like on OpenBSD and
FreeBSD, and both of those OSes have their own patches to work around this typo:

http://www.openbsd.org/cgi-bin/cvsweb/ports/www/chromium/patches/patch-skia_e...

http://www.freebsd.org/cgi/cvsweb.cgi/ports/www/chromium/files/patch-skia__ex...

[reed1, 2013-04-08 21:35:17]

lgtm

gotcha

[commit-bot: I haz the power, 2013-04-08 21:35:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mdempsky@google.com/13804003/1

[commit-bot: I haz the power, 2013-04-08 23:59:14]

Change committed as 192953