Delay fetching account info until OnRefreshTokensLoaded().

components/signin/core/browser/account_seeding_tracker.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_SIGNIN_CORE_BROWSER_ACCOUNT_SEEDING_TRACKER_H_
+#define COMPONENTS_SIGNIN_CORE_BROWSER_ACCOUNT_SEEDING_TRACKER_H_
+
+#include <string>
+#include <vector>
+
+#include "base/macros.h"
+#include "build/build_config.h"
+
+class AccountTrackerService;
+
+// AccountSeedingTracker keeps track of accounts that need to be seeded
+// partially. This is required on Android where the OS uses email as the
+// identifier for accounts whereas Chrome uses the GAIA ID.
+class AccountSeedingTracker {

[anthonyvd, 2015/10/05 16:05:50]

Since this class is so incredibly Android-specific, is there a way to just move
the work it does directly in AccountTrackerServiceAndroid?

[knn, 2015/10/05 16:35:55]

You can think of this as dividing the AccountFetcherService rather than ATS into
Android specific and general parts. Another way to accomplish the separation
would have been to subclass AFS but composition is cleaner imho.
AccountTrackerServiceAndroid is really just a Java bridge. Appreciate any rename
suggestions there.

[anthonyvd, 2015/10/05 20:45:21]

I see. Agreed that composition is better than inheritance.

My concern about this class is that it's present everywhere but only does
something on Android. For example, IsAccountSeeded() is misleading on desktop
because it always returns true, although that's not always correct. Same for
AreAllAccountsSeeded(), which is even worse since that doesn't really mean
anything except on Android.

I feel like this should be an Android-specific file/class (so only compile it
there and maybe have Android in the name) and the ATS can then decide if it uses
it depending on platform. WDYT?

+ public:
+  AccountSeedingTracker(const AccountTrackerService* account_tracker_service);
+  ~AccountSeedingTracker();
+
+  bool IsAccountSeeded(const std::string& account_id);
+  std::vector<std::string> GetNewlySeededAccounts();
+  bool AreAllAccountsSeeded() const;
+
+ private:
+#if defined(OS_ANDROID)
+  std::vector<std::string> unseeded_accounts_;
+  const AccountTrackerService* account_tracker_service_;
+#endif
+
+  DISALLOW_COPY_AND_ASSIGN(AccountSeedingTracker);
+};
+
+#endif  // COMPONENTS_SIGNIN_CORE_BROWSER_ACCOUNT_SEEDING_TRACKER_H_