Issue 13801018: Mac: Fix BMB commands triggering a standalone window instead of a sheet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13801018: Mac: Fix BMB commands triggering a standalone window instead of a sheet. (Closed)

Created:
7 years, 8 months ago by Alexei Svitkine (slow)

Modified:
7 years, 8 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, tfarina, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Mac: Fix BMB commands triggering a standalone window instead of a sheet. It was caused by -menu getting called before the view got added to the window, which was creating the C++ controller with a nil NSWindow. (This was being done by the localizer inspecting the view.) Add an early return in that case - so the menu only gets created once the view is attached to the window. BUG=227388 TEST=As per bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192958