Issue 13801010: Leak in ScreenshotTakerTest::TakeScreenshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13801010: Leak in ScreenshotTakerTest::TakeScreenshot (Closed)

Created:
7 years, 8 months ago by sschmitz

Modified:
7 years, 8 months ago

Reviewers:
Lei Zhang, James Cook

CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org, sadrul, timurrrr+watch_chromium.org, ben+watch_chromium.org, dhollowa

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Leak in ScreenshotTakerTest::TakeScreenshot Fixed memory leaks in ScreenshotTakerTest. Updated suppression files. Ran valgrind and heapcheck on my desktop. BUG=227271 TEST=manual unit_tests --gtest_filter='ScreenshotTakerTest.*' Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192987

Patch Set 1 : fix mem leaks #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -45 lines)			Patch
M	chrome/browser/ui/ash/screenshot_taker_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/heapcheck/suppressions.txt	View	1 chunk	+0 lines, -38 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

I'm going to defer to your original CL reviewer since I don't know this code. ...

7 years, 8 months ago (2013-04-08 22:16:17 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/13801010/3001

7 years, 8 months ago (2013-04-08 22:26:49 UTC) #4

Message was sent while issue was closed.

Change committed as 192987

Expand Messages | Collapse Messages